Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs

2014-01-21 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs

2014-01-21 Thread David Gil Oliva
> On Jan. 21, 2014, 11:43 p.m., Alex Merry wrote: > > Thanks for working on apidox! Sorry for the large number of comments... Wow! You were ultra-fast, just 31 minutes for all this! :-) I will see one by one tomorrow (just wanted to comment about something I clearly don't agree). > On Jan. 2

Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs

2014-01-22 Thread Alex Merry
> On Jan. 21, 2014, 11:43 p.m., Alex Merry wrote: > > src/kcompletion.h, line 103 > > > > > > You remove the hyphen from "auto-completion" ealier, but not here. > > David Gil Oliva wrote: > Yes, I drop the h

Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs

2014-01-22 Thread David Gil Oliva
> On Jan. 21, 2014, 11:43 p.m., Alex Merry wrote: > > src/kcompletion.h, line 501 > > > > > > One sentence: "This signal is emitted by makeCompletion() when a match > > is found. Since more methods emit this si

Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs

2014-01-23 Thread Alex Merry
> On Jan. 21, 2014, 11:43 p.m., Alex Merry wrote: > > src/kcompletion.h, line 501 > > > > > > One sentence: "This signal is emitted by makeCompletion() when a match > > is found. > > David Gil Oliva wrote: >

Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs

2014-01-26 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/ --- (Updated Jan. 26, 2014, 10:46 p.m.) Review request for KDE Frameworks.

Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs

2014-01-26 Thread David Gil Oliva
> On Jan. 21, 2014, 11:43 p.m., Alex Merry wrote: > > src/kcompletion.h, line 501 > > > > > > One sentence: "This signal is emitted by makeCompletion() when a match > > is found. > > David Gil Oliva wrote: >

Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs

2014-01-27 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/#review48374 --- Ship it! Just one more thing to check, then go ahead and comm

Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs

2014-01-27 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/ --- (Updated Jan. 27, 2014, 7:14 p.m.) Status -- This change has been ma

Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs

2014-01-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/#review48411 --- This review has been submitted with commit 5074495472c51c5139

Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs

2014-01-27 Thread David Gil Oliva
> On Jan. 27, 2014, 12:20 p.m., Alex Merry wrote: > > src/kcompletion.h, line 831 > > > > > > Does doxygen properly generate a link for this without the leading > > KCompletion::? Yes, it does. I've checked in