---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review52059
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/
---
(Updated March 5, 2014, 11:55 a.m.)
Status
--
This change has been
On Feb. 22, 2014, 9:09 a.m., David Faure wrote:
src/lib/kaboutdata.cpp, line 919
https://git.reviewboard.kde.org/r/115207/diff/3/?file=245365#file245365line919
A unittest would have shown you the bug in this line...
(you're modifying a copy - no effect).
Use
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/
---
(Updated March 4, 2014, 11:11 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review52006
---
Ship it!
Ship It!
- Kevin Ottens
On March 4, 2014, 11:11
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review52010
---
Ship it!
Ship It!
- David Faure
On March 4, 2014, 11:11
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/
---
(Updated Feb. 21, 2014, 12:26 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review50466
---
src/lib/kaboutdata.h
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/
---
(Updated Feb. 21, 2014, 2:03 p.m.)
Review request for KDE Frameworks.
On Jan. 27, 2014, 7:45 a.m., Kevin Ottens wrote:
src/lib/kaboutdata.cpp, line 941
https://git.reviewboard.kde.org/r/115207/diff/1/?file=235099#file235099line941
Not really my type of thing. It's acting on an object behind our back
without knowing... what happens to code where
On Jan. 27, 2014, 7:45 a.m., Kevin Ottens wrote:
src/lib/kaboutdata.cpp, line 941
https://git.reviewboard.kde.org/r/115207/diff/1/?file=235099#file235099line941
Not really my type of thing. It's acting on an object behind our back
without knowing... what happens to code where
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review48455
---
I agree with Kévin: this doesn't match what the function name
On Jan. 27, 2014, 7:45 a.m., Kevin Ottens wrote:
src/lib/kaboutdata.cpp, line 941
https://git.reviewboard.kde.org/r/115207/diff/1/?file=235099#file235099line941
Not really my type of thing. It's acting on an object behind our back
without knowing... what happens to code where
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/
---
Review request for KDE Frameworks.
Repository: kcoreaddons
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review47962
---
Think that will make porting easier and avoids boiler plate
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review47964
---
Looks like a good idea to me.
- Alex Merry
On Jan. 21,
16 matches
Mail list logo
