Review Request 115292: Do Configure Checks in the Correct Language

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115292/ --- Review request for KDE Frameworks and Alex Merry. Repository: kde4support

Re: Review Request 115292: Do Configure Checks in the Correct Language

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115292/#review48216 --- Patch fixes the issue for me here, think perhaps the same is n

Re: Review Request 115292: Do Configure Checks in the Correct Language

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115292/#review48219 --- src/ConfigureChecks.cmake

Re: Review Request 115292: Do Configure Checks in the Correct Language

> On Jan. 24, 2014, 2:17 p.m., Alex Merry wrote: > > src/ConfigureChecks.cmake, line 20 > > > > > > This is the underlying cause of the issue. I think the reason your > > changes fix it is the same reason removi

Re: Review Request 115292: Do Configure Checks in the Correct Language

> On Jan. 24, 2014, 2:17 p.m., Alex Merry wrote: > > src/ConfigureChecks.cmake, line 20 > > > > > > This is the underlying cause of the issue. I think the reason your > > changes fix it is the same reason removi

Re: Review Request 115292: Do Configure Checks in the Correct Language

> On Jan. 24, 2014, 2:17 p.m., Alex Merry wrote: > > src/ConfigureChecks.cmake, line 20 > > > > > > This is the underlying cause of the issue. I think the reason your > > changes fix it is the same reason removi

Re: Review Request 115292: Do Configure Checks in the Correct Language

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115292/#review48694 --- I'm slightly ambivilent about this, on the basis that my view

Re: Review Request 115292: Do Configure Checks in the Correct Language

> On Jan. 31, 2014, 6:31 p.m., Alex Merry wrote: > > src/ConfigureChecks.cmake, lines 87-88 > > > > > > Is this LANGUAGE stuff a cmake 3 feature, because it does not appear to > > exist in cmake 2.8.12 $ cmake

Re: Review Request 115292: Do Configure Checks in the Correct Language

> On Jan. 31, 2014, 6:31 p.m., Alex Merry wrote: > > src/ConfigureChecks.cmake, line 68 > > > > > > I believe this isn't even used any more It doesn't look like it is used, let me know if you want me to drop this

Re: Review Request 115292: Do Configure Checks in the Correct Language

> On Jan. 31, 2014, 6:31 p.m., Alex Merry wrote: > > src/ConfigureChecks.cmake, lines 87-88 > > > > > > Is this LANGUAGE stuff a cmake 3 feature, because it does not appear to > > exist in cmake 2.8.12 > > David

Re: Review Request 115292: Do Configure Checks in the Correct Language

> On Jan. 31, 2014, 6:31 p.m., Alex Merry wrote: > > src/ConfigureChecks.cmake, line 68 > > > > > > I believe this isn't even used any more > > David Narváez wrote: > It doesn't look like it is used, let me k

Re: Review Request 115292: Do Configure Checks in the Correct Language

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115292/#review48730 --- Ship it! OK, works fine with CMake 2.8.12.0 - Alex Merry O

Re: Review Request 115292: Do Configure Checks in the Correct Language

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115292/#review48732 --- This review has been submitted with commit 2134d30671c5cfd8da

Re: Review Request 115292: Do Configure Checks in the Correct Language

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115292/ --- (Updated Feb. 1, 2014, 3:39 a.m.) Status -- This change has been mar