Re: Review Request 115336: Change syntax of kservice_desktop_to_json

2014-02-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115336/#review48819 --- This review has been submitted with commit 594664a3169561fe15

Re: Review Request 115336: Change syntax of kservice_desktop_to_json

2014-02-03 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115336/ --- (Updated Feb. 3, 2014, 12:29 p.m.) Status -- This change has been ma

Re: Review Request 115336: Change syntax of kservice_desktop_to_json

2014-02-03 Thread Aurélien Gâteau
> On Jan. 31, 2014, 8:15 p.m., Alex Merry wrote: > > There was an optional jsonfile argument; I guess you checked nothing was > > using it? Because anything that was will be broken by this. > > > > That said, I have no objection to breaking source compatibility of > > something that hasn't ev

Re: Review Request 115336: Change syntax of kservice_desktop_to_json

2014-01-31 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115336/#review48705 --- Ship it! There was an optional jsonfile argument; I guess you

Review Request 115336: Change syntax of kservice_desktop_to_json

2014-01-27 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115336/ --- Review request for KDE Frameworks. Repository: kservice Description ---