Review Request 115494: Build on Mac OS X

2014-02-05 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115494/ --- Review request for KDE Frameworks. Repository: kjs Description ---

Re: Review Request 115494: Build on Mac OS X

2014-02-05 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115494/ --- (Updated Feb. 5, 2014, 1:42 p.m.) Review request for KDE Frameworks and

Re: Review Request 115494: Build on Mac OS X

2014-02-05 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115494/#review49027 --- src/kjs/ConfigureChecks.cmake

Re: Review Request 115494: Build on Mac OS X

2014-02-05 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115494/ --- (Updated Feb. 5, 2014, 4:06 p.m.) Review request for KDE Frameworks and

Re: Review Request 115494: Build on Mac OS X

2014-02-05 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115494/#review49051 --- Nope, still breaks on Linux. I think it's because cmath

Re: Review Request 115494: Build on Mac OS X

2014-02-05 Thread Bernd Buschinski
On Feb. 5, 2014, 5:04 p.m., Alex Merry wrote: Nope, still breaks on Linux. I think it's because cmath undefs the signbit macro. I propose https://git.reviewboard.kde.org/r/115502/ as the proper fix for this part of your request. I would also prefer

Re: Review Request 115494: Build on Mac OS X

2014-02-05 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115494/ --- (Updated Feb. 5, 2014, 8:38 p.m.) Status -- This change has been