Review Request 115635: Make kconfig_compiler signals actually useful

2014-02-10 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115635/ --- Review request for KDE Frameworks. Repository: kconfig Description

Re: Review Request 115635: Make kconfig_compiler signals actually useful

2014-02-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115635/#review49505 --- Just a note on process: the bugfix and the unittest for that b

Re: Review Request 115635: Make kconfig_compiler signals actually useful

2014-02-16 Thread Matthew John Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115635/#review50006 --- Looks good! I'd prefer to avoid the wrapper, but I can't see

Re: Review Request 115635: Make kconfig_compiler signals actually useful

2014-02-17 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115635/ --- (Updated Feb. 17, 2014, 4:44 p.m.) Review request for KDE Frameworks. C

Re: Review Request 115635: Make kconfig_compiler signals actually useful

2014-02-17 Thread Alexander Richardson
> On Feb. 17, 2014, 7:39 a.m., Matthew John Dawson wrote: > > src/kconfig_compiler/kconfig_compiler.cpp, line 1218 > > > > > > Coding style: please leave the braces for this if statement. I initially made this

Re: Review Request 115635: Make kconfig_compiler signals actually useful

2014-02-17 Thread Matthew John Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115635/#review50119 --- Ship it! Everything looks good here, I just have a quick coup

Re: Review Request 115635: Make kconfig_compiler signals actually useful

2014-02-20 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115635/ --- (Updated Feb. 20, 2014, 4:57 p.m.) Review request for KDE Frameworks. C

Re: Review Request 115635: Make kconfig_compiler signals actually useful

2014-02-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115635/#review50390 --- This review has been submitted with commit 6d3a4405fc2723f579

Re: Review Request 115635: Make kconfig_compiler signals actually useful

2014-02-20 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115635/ --- (Updated Feb. 20, 2014, 5:15 p.m.) Status -- This change has been ma