Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

2014-02-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115684/ --- (Updated Feb. 15, 2014, 7:22 p.m.) Status -- This change has been di

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

2014-02-15 Thread Alex Merry
> On Feb. 14, 2014, 3:26 p.m., Alex Merry wrote: > > OK, I'll be honest, something about this whole module interface rubs me up > > the wrong way. There's either too much or not enough magic: code that > > calls ecm_generate_headers needs to know things about the implementation > > and use th

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

2014-02-15 Thread Alex Merry
> On Feb. 14, 2014, 3:26 p.m., Alex Merry wrote: > > OK, I'll be honest, something about this whole module interface rubs me up > > the wrong way. There's either too much or not enough magic: code that > > calls ecm_generate_headers needs to know things about the implementation > > and use th

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

2014-02-15 Thread David Faure
> On Feb. 14, 2014, 3:26 p.m., Alex Merry wrote: > > OK, I'll be honest, something about this whole module interface rubs me up > > the wrong way. There's either too much or not enough magic: code that > > calls ecm_generate_headers needs to know things about the implementation > > and use th

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

2014-02-14 Thread Alex Merry
> On Feb. 14, 2014, 3:26 p.m., Alex Merry wrote: > > OK, I'll be honest, something about this whole module interface rubs me up > > the wrong way. There's either too much or not enough magic: code that > > calls ecm_generate_headers needs to know things about the implementation > > and use th

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

2014-02-14 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115684/#review49787 --- OK, I'll be honest, something about this whole module interfac

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

2014-02-12 Thread Harald Fernengel
> On Feb. 12, 2014, 12:20 a.m., Aleix Pol Gonzalez wrote: > > Makes sense to me, I most certainly didn't consider it as a problem. > > > > This could break compilation on some projects other than KParts, will you > > be able to try the rest of the modules? > > > > Thanks for figuring it out! >

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

2014-02-12 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115684/#review49655 --- Ship it! Ship It! - Harald Fernengel On Feb. 11, 2014, 10:

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

2014-02-12 Thread Alex Merry
> On Feb. 12, 2014, 12:20 a.m., Aleix Pol Gonzalez wrote: > > Makes sense to me, I most certainly didn't consider it as a problem. > > > > This could break compilation on some projects other than KParts, will you > > be able to try the rest of the modules? > > > > Thanks for figuring it out! >

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

2014-02-12 Thread David Faure
> On Feb. 12, 2014, 12:20 a.m., Aleix Pol Gonzalez wrote: > > Makes sense to me, I most certainly didn't consider it as a problem. > > > > This could break compilation on some projects other than KParts, will you > > be able to try the rest of the modules? > > > > Thanks for figuring it out!

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

2014-02-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115684/#review49615 --- Ship it! Makes sense to me, I most certainly didn't consider

Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

2014-02-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115684/ --- Review request for Build System, Extra Cmake Modules, KDE Frameworks, and