Re: Review Request 115695: Rework KNotification to work without KNotify daemon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/ --- (Updated Feb. 26, 2014, 4:53 p.m.) Status -- This change has been di

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/#review50447 --- Way to big to properly review to be honest. That said, I agree

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

> On Feb. 19, 2014, 7:06 a.m., Aleix Pol Gonzalez wrote: > > src/notifybypopupgrowl.h, line 37 > > > > > > Is growl still the thing for MacOS X? > > Martin Klapetek wrote: > I'm not sure to be honest...I've h

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

> On Feb. 19, 2014, 11:06 a.m., Aleix Pol Gonzalez wrote: > > src/knotificationmanager.cpp, line 180 > > > > > > ? > > Martin Klapetek wrote: > Yet once again the description xD - "it's full of ... FIXMEs to

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

> On Feb. 19, 2014, 10:06 a.m., Aleix Pol Gonzalez wrote: > > src/knotificationmanager.cpp, line 180 > > > > > > ? > > Martin Klapetek wrote: > Yet once again the description xD - "it's full of ... FIXMEs to

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

> On Feb. 19, 2014, 11:06 a.m., Aleix Pol Gonzalez wrote: > > src/knotificationmanager.cpp, line 66 > > > > > > This will be done in the future? Maybe it would be better to commit > > when there are no regression

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

> On Feb. 19, 2014, 11:06 a.m., Aleix Pol Gonzalez wrote: > > src/knotification.cpp, line 333 > > > > > > remove qDebugs? As the description says - "and for now it's full of QDebugs, that will all be removed" -

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/#review50197 --- src/knotification.cpp

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/#review50136 --- Ping, any comments? - Martin Klapetek On Feb. 13, 2014, 11:

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/ --- (Updated Feb. 13, 2014, 11:14 a.m.) Review request for kde-workspace, KDE

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/ --- (Updated Feb. 12, 2014, 4:54 p.m.) Review request for kde-workspace, KDE

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/#review49650 --- src/notifybypopup.cpp

Review Request 115695: Rework KNotification to work without KNotify daemon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/ --- Review request for kde-workspace, KDE Frameworks, Plasma, and Sune Vuorela.