Review Request 115708: Build on Mac OS X

2014-02-12 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115708/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano.

Re: Review Request 115708: Build on Mac OS X

2014-02-12 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115708/#review49680 --- src/CMakeLists.txt

Re: Review Request 115708: Build on Mac OS X

2014-02-12 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115708/#review49682 --- Ship it! It seems to work correctly, so ship it from my

Re: Review Request 115708: Build on Mac OS X

2014-02-12 Thread Luigi Toscano
On Feb. 12, 2014, 9:48 p.m., Harald Fernengel wrote: src/CMakeLists.txt, line 149 https://git.reviewboard.kde.org/r/115708/diff/1/?file=243799#file243799line149 Note - cmake is documented to replace the COMMAND by the actual command, as we added it with add_executable before.

Re: Review Request 115708: Build on Mac OS X

2014-02-12 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115708/ --- (Updated Feb. 13, 2014, 6:51 a.m.) Status -- This change has been