Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

2014-02-13 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115739/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

2014-02-13 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115739/#review49739 --- Making the type movable does not make QList store it directly,

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

2014-02-13 Thread Christoph Feck
> On Feb. 13, 2014, 9:31 p.m., Christoph Feck wrote: > > Making the type movable does not make QList store it directly, how did you > > check this? > > > > http://qt-project.org/doc/qt-5/qlist.html says: > > > > "Internally, QList is represented as an array of pointers to items of > > type T.

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

2014-02-13 Thread Frank Reininghaus
> On Feb. 13, 2014, 9:31 p.m., Christoph Feck wrote: > > Making the type movable does not make QList store it directly, how did you > > check this? > > > > http://qt-project.org/doc/qt-5/qlist.html says: > > > > "Internally, QList is represented as an array of pointers to items of > > type T.

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

2014-02-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115739/#review49873 --- Yeah the description is wrong. Making something Q_MOVABLE mean

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

2014-02-16 Thread Frank Reininghaus
> On Feb. 15, 2014, 8:28 p.m., David Faure wrote: > > Yeah the description is wrong. Making something Q_MOVABLE means that > > inserting into the list, or the copying that happens when reallocating for > > more space, will be able to memmove() instead of copy-constructing items. > > This doesn

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

2014-02-23 Thread David Faure
> On Feb. 15, 2014, 8:28 p.m., David Faure wrote: > > Yeah the description is wrong. Making something Q_MOVABLE means that > > inserting into the list, or the copying that happens when reallocating for > > more space, will be able to memmove() instead of copy-constructing items. > > This doesn

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

2014-02-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115739/#review50566 --- Ship it! Thanks! tests/listjobtest.cpp

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

2014-02-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115739/#review51000 --- This review has been submitted with commit c8168fe82ee26af0ec

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

2014-02-26 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115739/ --- (Updated Feb. 27, 2014, 7:52 a.m.) Status -- This change has been ma