Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

2014-03-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116689/ --- (Updated March 16, 2014, 11:03 a.m.) Status -- This change has been

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

2014-03-13 Thread Matthew Dawson
> On March 13, 2014, 3:54 p.m., Matthew Dawson wrote: > > src/core/kcoreconfigskeleton.cpp, line 990 > > > > > > Also, can you change the documentation for KCoreConfigSkeleton to > > reflect this change? Specif

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

2014-03-13 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116689/#review52913 --- Ship it! Ship It! - Matthew Dawson On March 13, 2014, 4:06

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

2014-03-13 Thread David Faure
> On March 13, 2014, 7:54 p.m., Matthew Dawson wrote: > > src/core/kcoreconfigskeleton.cpp, line 990 > > > > > > Also, can you change the documentation for KCoreConfigSkeleton to > > reflect this change? Specif

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

2014-03-13 Thread Matthew Dawson
> On March 13, 2014, 3:54 p.m., Matthew Dawson wrote: > > src/core/kcoreconfigskeleton.cpp, line 990 > > > > > > Also, can you change the documentation for KCoreConfigSkeleton to > > reflect this change? Specif

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

2014-03-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116689/ --- (Updated March 13, 2014, 8:06 p.m.) Review request for KDE Frameworks and

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

2014-03-13 Thread David Faure
> On March 13, 2014, 7:54 p.m., Matthew Dawson wrote: > > src/core/kconfigini.cpp, lines 86-89 > > > > > > Is there a reason for these extra debug statements? Argh, that stupid post-review script+alias always gra

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

2014-03-13 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116689/#review52902 --- Looks good, just a few items below: src/core/kconfigini.cpp

Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

2014-03-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116689/ --- Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig