Review Request 116766: Use a desktop file we might find for testing KServiceActions

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116766/ --- Review request for KDE Frameworks. Repository: kservice Description ---

Re: Review Request 116766: Use a desktop file we might find for testing KServiceActions

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116766/ --- (Updated March 12, 2014, 3:47 p.m.) Review request for KDE Frameworks and

Re: Review Request 116766: Use a desktop file we might find for testing KServiceActions

2014-03-12 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116766/#review52804 --- Looks fine to me. - Kevin Ottens On March 12, 2014, 3:47 p.

Re: Review Request 116766: Use a desktop file we might find for testing KServiceActions

2014-03-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116766/#review52874 --- It would have been better to just put a local copy of that des

Re: Review Request 116766: Use a desktop file we might find for testing KServiceActions

2014-03-13 Thread Alex Merry
> On March 13, 2014, 8:41 a.m., David Faure wrote: > > It would have been better to just put a local copy of that desktop file > > into the kservice autotests subdir, so that it's always available to run > > the test on. > > Now we depend on konsolerun.desktop which might change in the future,

Re: Review Request 116766: Use a desktop file we might find for testing KServiceActions

2014-03-13 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116766/ --- (Updated March 13, 2014, 11:27 a.m.) Status -- This change has been