Re: Review Request 116845: Make readConfig() non-virtual anymore, it's not useful. Remove unnecessary debug output Add KCoreConfigSkeleton::read() which doesn't call reparseConfiguration.

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116845/#review53864 --- This review has been submitted with commit c1980dbc51c9aa2770

Re: Review Request 116845: Make readConfig() non-virtual anymore, it's not useful. Remove unnecessary debug output Add KCoreConfigSkeleton::read() which doesn't call reparseConfiguration.

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116845/ --- (Updated March 23, 2014, 10 p.m.) Status -- This change has been mar

Re: Review Request 116845: Make readConfig() non-virtual anymore, it's not useful. Remove unnecessary debug output Add KCoreConfigSkeleton::read() which doesn't call reparseConfiguration.

2014-03-23 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116845/#review53862 --- Ship it! Everything seems fine for this to go in as is. The

Re: Review Request 116845: Make readConfig() non-virtual anymore, it's not useful. Remove unnecessary debug output Add KCoreConfigSkeleton::read() which doesn't call reparseConfiguration.

2014-03-23 Thread Matthew Dawson
> On March 16, 2014, 11:10 p.m., Matthew Dawson wrote: > > src/core/kcoreconfigskeleton.h, line 1055 > > > > > > I can't find any instances (lxr.kde.org returns way too many results to > > thoroughly check) whe

Re: Review Request 116845: Make readConfig() non-virtual anymore, it's not useful. Remove unnecessary debug output Add KCoreConfigSkeleton::read() which doesn't call reparseConfiguration.

2014-03-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116845/ --- (Updated March 17, 2014, 11:17 p.m.) Review request for KDE Frameworks an