Re: Review Request 116883: Fix KUserGroup::users() and KUserGroup::userNames() on UNIX

2014-03-27 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116883/ --- (Updated March 27, 2014, 6:30 p.m.) Status -- This change has been m

Re: Review Request 116883: Fix KUserGroup::users() and KUserGroup::userNames() on UNIX

2014-03-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116883/#review54358 --- This review has been submitted with commit 6ea3839a870ee9c99c

Re: Review Request 116883: Fix KUserGroup::users() and KUserGroup::userNames() on UNIX

2014-03-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116883/#review54303 --- Ship it! I think the template was fine too, but ok, let's go

Re: Review Request 116883: Fix KUserGroup::users() and KUserGroup::userNames() on UNIX

2014-03-19 Thread Milian Wolff
> On March 19, 2014, 2:56 a.m., Michael Pyne wrote: > > src/lib/util/kuser_unix.cpp, line 349 > > > > > > Does this need to be a template, or would std::function be sufficient? > > Templates have a poor reputati

Re: Review Request 116883: Fix KUserGroup::users() and KUserGroup::userNames() on UNIX

2014-03-19 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116883/ --- (Updated March 19, 2014, 9:20 a.m.) Review request for KDE Frameworks.

Re: Review Request 116883: Fix KUserGroup::users() and KUserGroup::userNames() on UNIX

2014-03-18 Thread Alexander Richardson
> On March 19, 2014, 3:56 a.m., Michael Pyne wrote: > > src/lib/util/kuser_unix.cpp, line 349 > > > > > > Does this need to be a template, or would std::function be sufficient? > > Templates have a poor reputati

Re: Review Request 116883: Fix KUserGroup::users() and KUserGroup::userNames() on UNIX

2014-03-18 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116883/#review53382 --- A couple questions, one of which needs resolved, but looks goo

Re: Review Request 116883: Fix KUserGroup::users() and KUserGroup::userNames() on UNIX

2014-03-18 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116883/ --- (Updated March 18, 2014, 10:20 p.m.) Review request for KDE Frameworks.

Review Request 116883: Fix KUserGroup::users() and KUserGroup::userNames() on UNIX

2014-03-18 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116883/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description