Re: Review Request 117010: Finish renames in KCoreConfigSkeleton, and stop doing extra loads as well.

2014-03-28 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117010/ --- (Updated March 28, 2014, 4:18 p.m.) Status -- This change has been m

Re: Review Request 117010: Finish renames in KCoreConfigSkeleton, and stop doing extra loads as well.

2014-03-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117010/#review54468 --- This review has been submitted with commit 4846b50aea0bc22622

Re: Review Request 117010: Finish renames in KCoreConfigSkeleton, and stop doing extra loads as well.

2014-03-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117010/#review54306 --- Ship it! This one should definitely be in for beta1. Please f

Re: Review Request 117010: Finish renames in KCoreConfigSkeleton, and stop doing extra loads as well.

2014-03-23 Thread Alexander Richardson
> On March 24, 2014, 12:22 a.m., David Faure wrote: > > src/core/kcoreconfigskeleton.cpp, line 1112 > > > > > > Won't this break with MSVC? Shouldn't break MSVC, it will just give a unknown pragma warning. Neve

Re: Review Request 117010: Finish renames in KCoreConfigSkeleton, and stop doing extra loads as well.

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117010/#review53876 --- Ah, the old usrReadConfig still exists, OK, that solves my wor

Review Request 117010: Finish renames in KCoreConfigSkeleton, and stop doing extra loads as well.

2014-03-23 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117010/ --- Review request for KDE Frameworks and David Faure. Repository: kconfig