Review Request 117049: Ensure that pluginVersion gets resolved for multiple KPluginLoader

2014-03-25 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117049/ --- Review request for KDE Frameworks and David Faure. Repository: kservice

Re: Review Request 117049: Ensure that pluginVersion gets resolved for multiple KPluginLoader

2014-03-26 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117049/#review54198 --- Looks sensible, but can you re-work the unittest to be integra

Re: Review Request 117049: Ensure that pluginVersion gets resolved for multiple KPluginLoader

2014-03-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117049/ --- (Updated March 26, 2014, 3:35 p.m.) Review request for KDE Frameworks and

Re: Review Request 117049: Ensure that pluginVersion gets resolved for multiple KPluginLoader

2014-03-26 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117049/#review54211 --- Ship it! Ship It! - Alex Merry On March 26, 2014, 2:35 p.m

Re: Review Request 117049: Ensure that pluginVersion gets resolved for multiple KPluginLoader

2014-03-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117049/ --- (Updated March 27, 2014, 6:20 a.m.) Status -- This change has been m

Re: Review Request 117049: Ensure that pluginVersion gets resolved for multiple KPluginLoader

2014-03-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117049/#review54263 --- This review has been submitted with commit dc155f4fd02a4dcaa0