Re: Review Request 117695: change where dynamic replace tabs is performed

2014-05-19 Thread Sven Brauch
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/ --- (Updated May 19, 2014, 10:36 p.m.) Status -- This change has been ma

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-05-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/#review58180 --- This review has been submitted with commit f9d33a959dd03cd4f3

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-05-19 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/#review58172 --- Ship it! I think that is a better way to handle it than the o

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-05-19 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/#review58165 --- Looks good to me. Still, Christoph, since it touches the core

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-05-12 Thread Kevin Ottens
> On May 7, 2014, 1:30 p.m., Sven Brauch wrote: > > Ping, any new opinions on this? Looks good to me, but I'd rather see someone more knowledgeable with ktexteditor give the ship it. - Kevin --- This is an automatically generated e-mai

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-05-07 Thread Sven Brauch
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/#review57494 --- Ping, any new opinions on this? - Sven Brauch On May 3, 201

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-05-02 Thread Sven Brauch
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/ --- (Updated May 3, 2014, 12:57 a.m.) Review request for KDE Frameworks and C

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-04-24 Thread Sven Brauch
> On April 24, 2014, 10:31 p.m., Kevin Ottens wrote: > > Any chance to have some unit tests? Sure, I'll add some shortly. - Sven --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/#r

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/#review56439 --- Any chance to have some unit tests? - Kevin Ottens On April

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-04-23 Thread Sven Brauch
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/ --- (Updated April 23, 2014, 11:15 a.m.) Review request for KDE Frameworks an

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-04-23 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/#review56264 --- src/document/katedocument.cpp

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-04-23 Thread Sven Brauch
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/ --- (Updated April 23, 2014, 8:49 a.m.) Review request for KDE Frameworks and

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-04-22 Thread Sven Brauch
> On April 22, 2014, 9:13 p.m., Matthew Woehlke wrote: > > If the option to reindent pasted code is enabled, does *that* still remove > > tabs? (Seems like you'd want it too in that case...) Seems it doesn't, I'll look after that. - Sven -

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-04-22 Thread Matthew Woehlke
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/#review56220 --- If the option to reindent pasted code is enabled, does *that*

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-04-22 Thread Sven Brauch
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/ --- (Updated April 22, 2014, 9:06 p.m.) Review request for KDE Frameworks and

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-04-22 Thread Sven Brauch
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/ --- (Updated April 22, 2014, 8:56 p.m.) Review request for KDE Frameworks and