Review Request 117701: Fix crashers in KStartupInfo on remove while iterating

2014-04-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117701/ --- Review request for KDE Frameworks, Àlex Fiestas and Bhushan Shah. Bugs: 3

Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating

2014-04-23 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117701/#review56270 --- +1, Just tested - Bhushan Shah On April 23, 2014, 3:05 p.m.

Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating

2014-04-23 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117701/#review56269 --- src/kstartupinfo.cpp

Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating

2014-04-23 Thread Martin Gräßlin
> On April 23, 2014, 3:03 p.m., Thomas Lübking wrote: > > src/kstartupinfo.cpp, line 413 > > > > > > this is somehow not equivalent to the other variant (ignores > > silent/uninited) - the iterator should perhap

Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating

2014-04-23 Thread Martin Gräßlin
> On April 23, 2014, 3:03 p.m., Thomas Lübking wrote: > > src/kstartupinfo.cpp, line 413 > > > > > > this is somehow not equivalent to the other variant (ignores > > silent/uninited) - the iterator should perhap

Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating

2014-04-23 Thread Martin Gräßlin
> On April 23, 2014, 3:03 p.m., Thomas Lübking wrote: > > src/kstartupinfo.cpp, line 413 > > > > > > this is somehow not equivalent to the other variant (ignores > > silent/uninited) - the iterator should perhap

Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating

2014-04-23 Thread Thomas Lübking
> On April 23, 2014, 1:03 p.m., Thomas Lübking wrote: > > src/kstartupinfo.cpp, line 413 > > > > > > this is somehow not equivalent to the other variant (ignores > > silent/uninited) - the iterator should perhap

Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating

2014-04-23 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117701/#review56333 --- Ship it! Ship It! - Thomas Lübking On April 23, 2014, 9:35

Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating

2014-04-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117701/ --- (Updated April 24, 2014, 7:27 a.m.) Review request for KDE Frameworks, Àl

Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117701/#review56446 --- Ship it! Ship It! - Kevin Ottens On April 24, 2014, 5:27 a

Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating

2014-04-25 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117701/ --- (Updated April 25, 2014, 7:03 a.m.) Status -- This change has been m

Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating

2014-04-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117701/#review56470 --- This review has been submitted with commit ba3fe29fe342d20caf