Review Request 117805: Introduce kdoctools_install()

2014-04-27 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117805/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano. Repos

Re: Review Request 117805: Introduce kdoctools_install()

2014-04-27 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117805/#review56700 --- I think you can simplify the match condition: manpages docbook

Re: Review Request 117805: Introduce kdoctools_install()

2014-04-27 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117805/#review56699 --- I think you can simplify the match condition: manpages docbook

Re: Review Request 117805: Introduce kdoctools_install()

2014-04-28 Thread Aurélien Gâteau
> On April 28, 2014, 1:31 a.m., Luigi Toscano wrote: > > I think you can simplify the match condition: manpages docbooks starts with > > "man-" prefix I didn't check on the "man-" prefix because a comment in kdoctools_create_manpage() says 'sometimes we have "man-" prepended'. Is it mandatory

Re: Review Request 117805: Introduce kdoctools_install()

2014-04-28 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117805/#review56764 --- KF5DocToolsMacros.cmake

Re: Review Request 117805: Introduce kdoctools_install()

2014-04-30 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117805/#review56979 --- KF5DocToolsMacros.cmake

Re: Review Request 117805: Introduce kdoctools_install()

2014-04-30 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117805/ --- (Updated April 30, 2014, 2:33 p.m.) Review request for Documentation, KDE

Re: Review Request 117805: Introduce kdoctools_install()

2014-04-30 Thread Aurélien Gâteau
> On April 28, 2014, 5:23 p.m., Burkhard Lück wrote: > > KF5DocToolsMacros.cmake, lines 220-221 > > > > > > kio/docs/kioslave/foo/CMakeLists.text have > > INSTALL_DESTINATION ${HTML_INSTALL_DIR}/en SUBDIR kio

Re: Review Request 117805: Introduce kdoctools_install()

2014-04-30 Thread Aurélien Gâteau
> On April 30, 2014, 2:16 p.m., Alex Merry wrote: > > KF5DocToolsMacros.cmake, line 201 > > > > > > I personally prefer to use lowercase for function names everywhere, > > including declarations. I prefer lower

Re: Review Request 117805: Introduce kdoctools_install()

2014-04-30 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117805/ --- (Updated April 30, 2014, 2:44 p.m.) Review request for Documentation, KDE

Re: Review Request 117805: Introduce kdoctools_install()

2014-04-30 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117805/#review57037 --- Ship it! Looks fine, thanks - Luigi Toscano On April 30, 2

Re: Review Request 117805: Introduce kdoctools_install()

2014-05-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117805/#review57159 --- This review has been submitted with commit 8930b2fd3336101336

Re: Review Request 117805: Introduce kdoctools_install()

2014-05-02 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117805/ --- (Updated May 2, 2014, 8:01 p.m.) Status -- This change has been mark