Review Request 117919: kcoreaddons: Move license-related KAboutData enums to KAboutLicense.

2014-04-30 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117919/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 117919: kcoreaddons: Move license-related KAboutData enums to KAboutLicense.

2014-05-06 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117919/#review57469 --- Ping? It hasn't quite been a week, but on the other hand there

Re: Review Request 117919: kcoreaddons: Move license-related KAboutData enums to KAboutLicense.

2014-05-12 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117919/#review57786 --- Ship it! Indeed looks like something which got forgotten alon

Re: Review Request 117919: kcoreaddons: Move license-related KAboutData enums to KAboutLicense.

2014-05-12 Thread Michael Pyne
> On May 12, 2014, 3:18 p.m., Kevin Ottens wrote: > > Indeed looks like something which got forgotten along the way. K4About* is > > supposed to be the porting tool, so let's have this one in even if that's > > SIC. To be clear, should I remove the deprecated ctor too, or just the deprecated

Re: Review Request 117919: kcoreaddons: Move license-related KAboutData enums to KAboutLicense.

2014-05-13 Thread Alex Merry
> On May 12, 2014, 3:18 p.m., Kevin Ottens wrote: > > Indeed looks like something which got forgotten along the way. K4About* is > > supposed to be the porting tool, so let's have this one in even if that's > > SIC. > > Michael Pyne wrote: > To be clear, should I remove the deprecated ctor

Re: Review Request 117919: kcoreaddons: Move license-related KAboutData enums to KAboutLicense.

2014-05-13 Thread Michael Pyne
> On May 12, 2014, 3:18 p.m., Kevin Ottens wrote: > > Indeed looks like something which got forgotten along the way. K4About* is > > supposed to be the porting tool, so let's have this one in even if that's > > SIC. > > Michael Pyne wrote: > To be clear, should I remove the deprecated ctor

Re: Review Request 117919: kcoreaddons: Move license-related KAboutData enums to KAboutLicense.

2014-05-13 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117919/ --- (Updated May 13, 2014, 11:52 p.m.) Status -- This change has been ma

Re: Review Request 117919: kcoreaddons: Move license-related KAboutData enums to KAboutLicense.

2014-05-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117919/#review57900 --- This review has been submitted with commit 5a7c1d6686e5f6d7fe

Re: Review Request 117919: kcoreaddons: Move license-related KAboutData enums to KAboutLicense.

2014-05-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117919/#review57910 --- Note that this broke lots of KAboutData uses. Please, when do

Re: Review Request 117919: kcoreaddons: Move license-related KAboutData enums to KAboutLicense.

2014-05-15 Thread Michael Pyne
> On May 14, 2014, 10:48 a.m., Aleix Pol Gonzalez wrote: > > Note that this broke lots of KAboutData uses. > > > > Please, when doing such changes remember there's things already ported. Yes, my apologies. But the pain this change would cause if implemented (and the inconsistent nature of hav

Re: Review Request 117919: kcoreaddons: Move license-related KAboutData enums to KAboutLicense.

2014-05-15 Thread Aleix Pol Gonzalez
> On May 14, 2014, 10:48 a.m., Aleix Pol Gonzalez wrote: > > Note that this broke lots of KAboutData uses. > > > > Please, when doing such changes remember there's things already ported. > > Michael Pyne wrote: > Yes, my apologies. > > But the pain this change would cause if implem