---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117919/
---
Review request for KDE Frameworks.
Repository: kcoreaddons
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117919/#review57469
---
Ping? It hasn't quite been a week, but on the other hand there
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117919/#review57786
---
Ship it!
Indeed looks like something which got forgotten alon
> On May 12, 2014, 3:18 p.m., Kevin Ottens wrote:
> > Indeed looks like something which got forgotten along the way. K4About* is
> > supposed to be the porting tool, so let's have this one in even if that's
> > SIC.
To be clear, should I remove the deprecated ctor too, or just the deprecated
> On May 12, 2014, 3:18 p.m., Kevin Ottens wrote:
> > Indeed looks like something which got forgotten along the way. K4About* is
> > supposed to be the porting tool, so let's have this one in even if that's
> > SIC.
>
> Michael Pyne wrote:
> To be clear, should I remove the deprecated ctor
> On May 12, 2014, 3:18 p.m., Kevin Ottens wrote:
> > Indeed looks like something which got forgotten along the way. K4About* is
> > supposed to be the porting tool, so let's have this one in even if that's
> > SIC.
>
> Michael Pyne wrote:
> To be clear, should I remove the deprecated ctor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117919/
---
(Updated May 13, 2014, 11:52 p.m.)
Status
--
This change has been ma
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117919/#review57900
---
This review has been submitted with commit
5a7c1d6686e5f6d7fe
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117919/#review57910
---
Note that this broke lots of KAboutData uses.
Please, when do
> On May 14, 2014, 10:48 a.m., Aleix Pol Gonzalez wrote:
> > Note that this broke lots of KAboutData uses.
> >
> > Please, when doing such changes remember there's things already ported.
Yes, my apologies.
But the pain this change would cause if implemented (and the inconsistent
nature of hav
> On May 14, 2014, 10:48 a.m., Aleix Pol Gonzalez wrote:
> > Note that this broke lots of KAboutData uses.
> >
> > Please, when doing such changes remember there's things already ported.
>
> Michael Pyne wrote:
> Yes, my apologies.
>
> But the pain this change would cause if implem
11 matches
Mail list logo