Re: Review Request 117974: Some more KArchive examples

2014-06-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117974/#review60359 --- This review has been submitted with commit

Re: Review Request 117974: Some more KArchive examples

2014-06-18 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117974/ --- (Updated June 18, 2014, 7:46 a.m.) Status -- This change has been

Re: Review Request 117974: Some more KArchive examples

2014-06-17 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117974/#review60278 --- Ship it! Ship It! - Kevin Ottens On June 6, 2014, 7:15

Re: Review Request 117974: Some more KArchive examples

2014-06-06 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117974/ --- (Updated June 6, 2014, 7:15 p.m.) Review request for KDE Frameworks.

Re: Review Request 117974: Some more KArchive examples

2014-06-06 Thread Maarten De Meyer
On May 12, 2014, 3:16 p.m., Kevin Ottens wrote: examples/bzip2gzip/main.cpp, line 74 https://git.reviewboard.kde.org/r/117974/diff/1/?file=271400#file271400line74 Maybe a better idea to use a loop to avoid the readAll? I know that's an example which needs to be kept simple, but

Re: Review Request 117974: Some more KArchive examples

2014-05-29 Thread Alex Merry
On May 12, 2014, 3:16 p.m., Kevin Ottens wrote: examples/bzip2gzip/main.cpp, line 74 https://git.reviewboard.kde.org/r/117974/diff/1/?file=271400#file271400line74 Maybe a better idea to use a loop to avoid the readAll? I know that's an example which needs to be kept simple, but

Review Request 117974: Some more KArchive examples

2014-05-03 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117974/ --- Review request for KDE Frameworks. Repository: karchive Description