Re: Review Request 118004: Fix support for installing files named the same in different directories with kdoctools_install

2014-05-07 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118004/ --- (Updated May 7, 2014, 12:44 p.m.) Status -- This change has been mar

Re: Review Request 118004: Fix support for installing files named the same in different directories with kdoctools_install

2014-05-07 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118004/#review57491 --- This review has been submitted with commit 28ad7396f2281b5190

Re: Review Request 118004: Fix support for installing files named the same in different directories with kdoctools_install

2014-05-06 Thread Luigi Toscano
> On May 6, 2014, 11:01 a.m., Aurélien Gâteau wrote: > > I realized I left one code untouched: the KDOCTOOLS_ENABLE_HTMLHANDBOOK > > block. What should be done with it? The option is not documented: is it > > obsolete? If I understand it correctly, the code generates .html files in > > the sou

Re: Review Request 118004: Fix support for installing files named the same in different directories with kdoctools_install

2014-05-06 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118004/#review57466 --- Ship it! Thanks - Luigi Toscano On May 6, 2014, 10:59 a.m.

Re: Review Request 118004: Fix support for installing files named the same in different directories with kdoctools_install

2014-05-06 Thread David Faure
> On May 6, 2014, 9:01 a.m., Aurélien Gâteau wrote: > > I realized I left one code untouched: the KDOCTOOLS_ENABLE_HTMLHANDBOOK > > block. What should be done with it? The option is not documented: is it > > obsolete? If I understand it correctly, the code generates .html files in > > the sour

Re: Review Request 118004: Fix support for installing files named the same in different directories with kdoctools_install

2014-05-06 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118004/#review57393 --- I realized I left one code untouched: the KDOCTOOLS_ENABLE_HTM

Re: Review Request 118004: Fix support for installing files named the same in different directories with kdoctools_install

2014-05-06 Thread Aurélien Gâteau
> On May 6, 2014, 1:03 a.m., Luigi Toscano wrote: > > Is the po-off directory really needed in the example? Oups. No it's not. Removed. - Aurélien --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.k

Re: Review Request 118004: Fix support for installing files named the same in different directories with kdoctools_install

2014-05-06 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118004/ --- (Updated May 6, 2014, 10:59 a.m.) Review request for Documentation, KDE F

Re: Review Request 118004: Fix support for installing files named the same in different directories with kdoctools_install

2014-05-06 Thread Aurélien Gâteau
> On May 6, 2014, 1:03 a.m., Luigi Toscano wrote: > > KF5DocToolsMacros.cmake, line 110 > > > > > > Does it work on Windows? (not sure how cmake deals with the different > > separator there). > > Also: the o

Re: Review Request 118004: Fix support for installing files named the same in different directories with kdoctools_install

2014-05-06 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118004/ --- (Updated May 6, 2014, 10:56 a.m.) Review request for Documentation, KDE F

Re: Review Request 118004: Fix support for installing files named the same in different directories with kdoctools_install

2014-05-05 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118004/#review57363 --- Is the po-off directory really needed in the example? KF5Doc

Review Request 118004: Fix support for installing files named the same in different directories with kdoctools_install

2014-05-05 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118004/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano. Repos