Re: Review Request 118071: add a message to the assertion

2014-05-11 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118071/ --- (Updated May 11, 2014, 2:32 p.m.) Status -- This change has been mar

Re: Review Request 118071: add a message to the assertion

2014-05-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118071/#review57718 --- This review has been submitted with commit 302658091c6da79592

Re: Review Request 118071: add a message to the assertion

2014-05-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118071/#review57702 --- Ship it! Ship It! - David Faure On May 10, 2014, 1:57 p.m.

Re: Review Request 118071: add a message to the assertion

2014-05-10 Thread Alexander Richardson
> On May 10, 2014, 3:59 p.m., Mark Gaiser wrote: > > src/services/kservicetypefactory.cpp, line 38 > > > > > > You have a double ";;" ;) Ah nice catch, will fix that before comitting - Alexander -

Re: Review Request 118071: add a message to the assertion

2014-05-10 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118071/#review57678 --- src/services/kservicetypefactory.cpp

Review Request 118071: add a message to the assertion

2014-05-10 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118071/ --- Review request for KDE Frameworks. Repository: kservice Description ---