Re: Review Request 118193: Use the macros provided by KDesignerPlugin

2014-06-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118193/#review58893 --- This review has been submitted with commit 73294b2e0d562b79f1

Re: Review Request 118193: Use the macros provided by KDesignerPlugin

2014-06-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118193/ --- (Updated June 1, 2014, 12:55 p.m.) Status -- This change has been ma

Re: Review Request 118193: Use the macros provided by KDesignerPlugin

2014-05-28 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118193/#review58667 --- Ship it! Ship It! - Aurélien Gâteau On May 18, 2014, 2:13

Re: Review Request 118193: Use the macros provided by KDesignerPlugin

2014-05-28 Thread Aurélien Gâteau
> On May 28, 2014, 2:23 p.m., Aurélien Gâteau wrote: > > Does not build here: CMake complains that kf5designerplugin_add_plugin() > > does not exist. > > > > If I replace it with kf5designerplugin_add_widget_files() then it says > > "Cannot specify link libraries for target "kdedeprecated" whi

Re: Review Request 118193: Use the macros provided by KDesignerPlugin

2014-05-28 Thread Alex Merry
> On May 28, 2014, 12:23 p.m., Aurélien Gâteau wrote: > > Does not build here: CMake complains that kf5designerplugin_add_plugin() > > does not exist. > > > > If I replace it with kf5designerplugin_add_widget_files() then it says > > "Cannot specify link libraries for target "kdedeprecated" wh

Re: Review Request 118193: Use the macros provided by KDesignerPlugin

2014-05-28 Thread Aurélien Gâteau
> On May 28, 2014, 2:23 p.m., Aurélien Gâteau wrote: > > Does not build here: CMake complains that kf5designerplugin_add_plugin() > > does not exist. > > > > If I replace it with kf5designerplugin_add_widget_files() then it says > > "Cannot specify link libraries for target "kdedeprecated" whi

Re: Review Request 118193: Use the macros provided by KDesignerPlugin

2014-05-28 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118193/#review58654 --- Does not build here: CMake complains that kf5designerplugin_ad

Review Request 118193: Use the macros provided by KDesignerPlugin

2014-05-18 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118193/ --- Review request for KDE Frameworks. Repository: kdelibs4support Descript