Re: Review Request 118489: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

2014-06-04 Thread Alex Merry
> On June 3, 2014, 10:12 a.m., Alex Merry wrote: > > Changing the macro name is a no-brainer. Comments below; a lot of them are > > about binary compatibility issues, and these depend on how we expect this > > macro to be used. I believe that Qt5 makes all its deprecated functions > > header-o

Re: Review Request 118489: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

2014-06-03 Thread Matthew Dawson
> On June 3, 2014, 6:12 a.m., Alex Merry wrote: > > Changing the macro name is a no-brainer. Comments below; a lot of them are > > about binary compatibility issues, and these depend on how we expect this > > macro to be used. I believe that Qt5 makes all its deprecated functions > > header-on

Re: Review Request 118489: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

2014-06-03 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118489/#review59060 --- Changing the macro name is a no-brainer. Comments below; a lot

Review Request 118489: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

2014-06-02 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118489/ --- Review request for KDE Frameworks. Repository: kconfig Description