> On June 12, 2014, 7:23 p.m., Aleix Pol Gonzalez wrote:
> > Would it make sense to backport that change to kdelibs4?
Just looked at kdelibs4 code: the bug cannot happen there because finished() is
always emitted after okClicked(). (in kdelibs4 all of those were handled by
KDialog)
- Aurélie
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118639/
---
(Updated June 13, 2014, 7:41 a.m.)
Status
--
This change has been ma
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118639/#review59933
---
This review has been submitted with commit
cc99fac3af737619ea
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118639/#review59889
---
Would it make sense to backport that change to kdelibs4?
- Al
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118639/#review59886
---
Ship it!
Good catch!
I can confirm that this makes saving th
> On June 10, 2014, 10:34 p.m., David Edmundson wrote:
> > Is this the cause of https://bugs.kde.org/show_bug.cgi?id=334624 ?
> >
> > This fix looks sensible to me.
I think it is, you are better at fishing bugs from bugzilla than I am :)
- Aurélien
--
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118639/
---
(Updated June 10, 2014, 10:45 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118639/#review59723
---
Is this the cause of https://bugs.kde.org/show_bug.cgi?id=3346
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118639/
---
Review request for KDE Frameworks.
Repository: kcmutils
Description
---
