Re: Review Request 118690: Introduce a KLocalizedTranslator

2014-06-18 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118690/ --- (Updated June 18, 2014, 12:21 p.m.) Status -- This change has been m

Re: Review Request 118690: Introduce a KLocalizedTranslator

2014-06-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118690/#review60388 --- This review has been submitted with commit 72d411a775b407d1e4

Re: Review Request 118690: Introduce a KLocalizedTranslator

2014-06-18 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118690/#review60357 --- Ship it! Ship It! - Chusslove Illich On June 12, 2014, 10:

Re: Review Request 118690: Introduce a KLocalizedTranslator

2014-06-17 Thread Aleix Pol Gonzalez
> On June 12, 2014, 11:06 p.m., Albert Astals Cid wrote: > > What's the use case? Didn't we have a different way for translating ui > > files? > > Martin Gräßlin wrote: > > What's the use case? > > well as explained in the comment for translating dynamically loaded UI > files. Whe

Re: Review Request 118690: Introduce a KLocalizedTranslator

2014-06-17 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118690/#review60286 --- Ship it! Independent from the (needed) change for "uic -tr i1

Re: Review Request 118690: Introduce a KLocalizedTranslator

2014-06-15 Thread Aleix Pol Gonzalez
> On June 12, 2014, 11:06 p.m., Albert Astals Cid wrote: > > What's the use case? Didn't we have a different way for translating ui > > files? > > Martin Gräßlin wrote: > > What's the use case? > > well as explained in the comment for translating dynamically loaded UI > files. Whe

Re: Review Request 118690: Introduce a KLocalizedTranslator

2014-06-15 Thread Albert Astals Cid
> On June 12, 2014, 11:06 p.m., Albert Astals Cid wrote: > > What's the use case? Didn't we have a different way for translating ui > > files? > > Martin Gräßlin wrote: > > What's the use case? > > well as explained in the comment for translating dynamically loaded UI > files. Whe

Re: Review Request 118690: Introduce a KLocalizedTranslator

2014-06-13 Thread Chusslove Illich
> On June 13, 2014, 1:06 a.m., Albert Astals Cid wrote: > > What's the use case? Didn't we have a different way for translating ui > > files? > > Martin Gräßlin wrote: > > What's the use case? > > well as explained in the comment for translating dynamically loaded UI > files. Wher

Re: Review Request 118690: Introduce a KLocalizedTranslator

2014-06-12 Thread Martin Gräßlin
> On June 13, 2014, 1:06 a.m., Albert Astals Cid wrote: > > What's the use case? Didn't we have a different way for translating ui > > files? > What's the use case? well as explained in the comment for translating dynamically loaded UI files. Where is that used? In KWin for the configuration

Re: Review Request 118690: Introduce a KLocalizedTranslator

2014-06-12 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118690/#review59925 --- What's the use case? Didn't we have a different way for transl

Review Request 118690: Introduce a KLocalizedTranslator

2014-06-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118690/ --- Review request for KDE Frameworks, Aurélien Gâteau and Chusslove Illich.