Re: Review Request 118692: Fix reading of entries for language/country combinations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/ --- (Updated June 21, 2014, 5:47 a.m.) Status -- This change has been ma

Re: Review Request 118692: Fix reading of entries for language/country combinations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/#review60635 --- This review has been submitted with commit a52b00f31eb5df1cd6

Re: Review Request 118692: Fix reading of entries for language/country combinations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/#review60621 --- Ship it! Ship It! - Matthew Dawson On June 20, 2014, 4:56

Re: Review Request 118692: Fix reading of entries for language/country combinations

> On June 17, 2014, 6:50 p.m., Matthew Dawson wrote: > > autotests/kdesktopfiletest.cpp, line 88 > > > > > > Please add a test for both: > > - when both the country/language match and a modifier is included

Re: Review Request 118692: Fix reading of entries for language/country combinations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/ --- (Updated June 20, 2014, 10:56 a.m.) Review request for KDE Frameworks, Da

Re: Review Request 118692: Fix reading of entries for language/country combinations

> On June 18, 2014, 12:50 a.m., Matthew Dawson wrote: > > autotests/kdesktopfiletest.cpp, line 88 > > > > > > Please add a test for both: > > - when both the country/language match and a modifier is include

Re: Review Request 118692: Fix reading of entries for language/country combinations

> On June 18, 2014, 3:04 a.m., Oswald Buddenhagen wrote: > > i don't see that you are proactively excluding the @modifier. it would seem > > that it's effectively part of the country, and the test works only because > > it's expected to fall back to de instead of de_AT anyway. > > > > there is

Re: Review Request 118692: Fix reading of entries for language/country combinations

> On June 12, 2014, 1:58 p.m., David Faure wrote: > > Looks good; but I'm surprised that it works :) the code for using fallbacks > > must be in there somewhere already then? (if de_DE not present then use > > de). > > This patch is only about not skipping these two entries (de and de_CH), but

Re: Review Request 118692: Fix reading of entries for language/country combinations

> On June 12, 2014, 1:58 p.m., David Faure wrote: > > Looks good; but I'm surprised that it works :) the code for using fallbacks > > must be in there somewhere already then? (if de_DE not present then use > > de). > > This patch is only about not skipping these two entries (de and de_CH), but

Re: Review Request 118692: Fix reading of entries for language/country combinations

> On June 12, 2014, 1:58 p.m., David Faure wrote: > > Looks good; but I'm surprised that it works :) the code for using fallbacks > > must be in there somewhere already then? (if de_DE not present then use > > de). > > This patch is only about not skipping these two entries (de and de_CH), but

Re: Review Request 118692: Fix reading of entries for language/country combinations

> On June 12, 2014, 1:58 p.m., David Faure wrote: > > Looks good; but I'm surprised that it works :) the code for using fallbacks > > must be in there somewhere already then? (if de_DE not present then use > > de). > > This patch is only about not skipping these two entries (de and de_CH), but

Re: Review Request 118692: Fix reading of entries for language/country combinations

> On June 17, 2014, 6:50 p.m., Matthew Dawson wrote: > > src/core/kconfigdata.h, line 206 > > > > > > Another Q_NULLPTR > > Martin Gräßlin wrote: > sorry, but what is wrong with Q_NULLPTR? I was commentin

Re: Review Request 118692: Fix reading of entries for language/country combinations

> On June 18, 2014, 12:50 a.m., Matthew Dawson wrote: > > src/core/kconfigdata.h, line 206 > > > > > > Another Q_NULLPTR sorry, but what is wrong with Q_NULLPTR? - Martin --

Re: Review Request 118692: Fix reading of entries for language/country combinations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/#review60351 --- i don't see that you are proactively excluding the @modifier.

Re: Review Request 118692: Fix reading of entries for language/country combinations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/#review60336 --- Ship it! LGTM. Just a couple of minor issues, and a couple m

Re: Review Request 118692: Fix reading of entries for language/country combinations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/ --- (Updated June 16, 2014, 10:26 a.m.) Review request for KDE Frameworks, Da

Re: Review Request 118692: Fix reading of entries for language/country combinations

> On June 14, 2014, 11:36 a.m., Oswald Buddenhagen wrote: > > src/core/kconfigdata.h, line 68 > > > > > > i didn't bother to re-read the whole code, so maybe that's why i can't > > claim to understand how that is

Re: Review Request 118692: Fix reading of entries for language/country combinations

> On June 14, 2014, 9:36 a.m., Oswald Buddenhagen wrote: > > src/core/kconfigdata.h, line 68 > > > > > > i didn't bother to re-read the whole code, so maybe that's why i can't > > claim to understand how that is

Re: Review Request 118692: Fix reading of entries for language/country combinations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/#review60067 --- autotests/kdesktopfiletest.cpp

Re: Review Request 118692: Fix reading of entries for language/country combinations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/ --- (Updated June 14, 2014, 8:24 a.m.) Review request for KDE Frameworks, Dav

Re: Review Request 118692: Fix reading of entries for language/country combinations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/ --- (Updated June 12, 2014, 4:17 p.m.) Review request for KDE Frameworks, Dav

Re: Review Request 118692: Fix reading of entries for language/country combinations

> On June 12, 2014, 12:54 p.m., Aleix Pol Gonzalez wrote: > > src/core/kconfigini.cpp, line 79 > > > > > > Is it really like that? > > > > I think the catalan locale is es_CA, and the short representation

Re: Review Request 118692: Fix reading of entries for language/country combinations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/#review59880 --- src/core/kconfigini.cpp

Re: Review Request 118692: Fix reading of entries for language/country combinations

> On June 12, 2014, 1:58 p.m., David Faure wrote: > > Looks good; but I'm surprised that it works :) the code for using fallbacks > > must be in there somewhere already then? (if de_DE not present then use > > de). > > This patch is only about not skipping these two entries (de and de_CH), but

Re: Review Request 118692: Fix reading of entries for language/country combinations

> On June 12, 2014, 11:58 a.m., David Faure wrote: > > Looks good; but I'm surprised that it works :) the code for using fallbacks > > must be in there somewhere already then? (if de_DE not present then use > > de). > > This patch is only about not skipping these two entries (de and de_CH), bu

Re: Review Request 118692: Fix reading of entries for language/country combinations

> On June 12, 2014, 1:58 p.m., David Faure wrote: > > Looks good; but I'm surprised that it works :) the code for using fallbacks > > must be in there somewhere already then? (if de_DE not present then use > > de). > > This patch is only about not skipping these two entries (de and de_CH), but

Re: Review Request 118692: Fix reading of entries for language/country combinations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/#review59869 --- Looks good; but I'm surprised that it works :) the code for us

Review Request 118692: Fix reading of entries for language/country combinations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/ --- Review request for KDE Frameworks, David Faure and John Layt. Repository: