Re: Review Request 118716: New Translations KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/ --- (Updated June 16, 2014, 12:58 a.m.) Review request for KDE Frameworks, Pl

Re: Review Request 118716: New Translations KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/ --- (Updated June 16, 2014, 12:57 a.m.) Review request for KDE Frameworks, Pl

Re: Review Request 118716: New Translations KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/ --- (Updated June 16, 2014, 12:45 a.m.) Review request for KDE Frameworks, Pl

Re: Review Request 118716: New Translations KCM

> On June 13, 2014, 11:53 a.m., Martin Klapetek wrote: > > kcms/translations/kcmtranslations.cpp, line 49 > > > > > > Why are you having John's name translated? ;) > > Chusslove Illich wrote: > Because he wil

Re: Review Request 118716: New Translations KCM

> On June 13, 2014, 11:53 a.m., Martin Klapetek wrote: > > kcms/translations/kcmtranslations.cpp, line 49 > > > > > > Why are you having John's name translated? ;) > > Chusslove Illich wrote: > Because he wil

Re: Review Request 118716: New Translations KCM

> On June 13, 2014, 11:53 a.m., Martin Klapetek wrote: > > kcms/translations/kcmtranslations.cpp, line 49 > > > > > > Why are you having John's name translated? ;) > > Chusslove Illich wrote: > Because he wil

Re: Review Request 118716: New Translations KCM

> On June 13, 2014, 11:59 a.m., Martin Gräßlin wrote: > > kcms/translations/kcmtranslations.cpp, lines 54-55 > > > > > > this is a library. One may NEVER use setApplicationDomain in a library, > > it would break

Re: Review Request 118716: New Translations KCM

> On June 13, 2014, 11:53 a.m., Martin Klapetek wrote: > > kcms/translations/kcmtranslations.cpp, line 49 > > > > > > Why are you having John's name translated? ;) Because he will be ??? in my language. -

Re: Review Request 118716: New Translations KCM

> On June 13, 2014, 9:59 a.m., Martin Gräßlin wrote: > > kcms/translations/kcmtranslations.cpp, lines 54-55 > > > > > > this is a library. One may NEVER use setApplicationDomain in a library, > > it would break t

Re: Review Request 118716: New Translations KCM

> On June 13, 2014, 11:59 a.m., Martin Gräßlin wrote: > > kcms/translations/kcmtranslations.cpp, lines 54-55 > > > > > > this is a library. One may NEVER use setApplicationDomain in a library, > > it would break

Re: Review Request 118716: New Translations KCM

> On June 13, 2014, 9:59 a.m., Martin Gräßlin wrote: > > kcms/translations/kcmtranslations.cpp, lines 54-55 > > > > > > this is a library. One may NEVER use setApplicationDomain in a library, > > it would break t

Re: Review Request 118716: New Translations KCM

> On June 13, 2014, 11:49 a.m., Martin Gräßlin wrote: > > kcms/translations/CMakeLists.txt, line 13 > > > > > > new code shouldn't use kdelibs4support There doesn't seem to be an equivalent for translation change

Re: Review Request 118716: New Translations KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/#review59968 --- kcms/translations/CMakeLists.txt

Re: Review Request 118716: New Translations KCM

> On June 13, 2014, 11:59 a.m., Martin Gräßlin wrote: > > kcms/translations/kcmtranslations.cpp, lines 54-55 > > > > > > this is a library. One may NEVER use setApplicationDomain in a library, > > it would break

Re: Review Request 118716: New Translations KCM

> On June 13, 2014, 9:59 a.m., Martin Gräßlin wrote: > > kcms/translations/kcmtranslations.cpp, lines 54-55 > > > > > > this is a library. One may NEVER use setApplicationDomain in a library, > > it would break t

Re: Review Request 118716: New Translations KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/#review59954 --- kcms/translations/kcmtranslations.cpp

Re: Review Request 118716: New Translations KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/#review59952 --- kcms/translations/kcmtranslations.cpp

Re: Review Request 118716: New Translations KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/#review59949 --- +9000 for the ever present comments! kcms/translations/kcmtr

Re: Review Request 118716: New Translations KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/ --- (Updated June 13, 2014, 2:31 a.m.) Review request for KDE Frameworks, Pla

Review Request 118716: New Translations KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/ --- Review request for KDE Frameworks, Plasma, Chusslove Illich, and John Layt.