Review Request 119251: Fix a conflict with KCrash where the function is declared as exported

2014-07-12 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119251/ --- Review request for KDE Frameworks and kdewin. Repository: kcoreaddons

Re: Review Request 119251: Fix a conflict with KCrash where the function is declared as exported

2014-07-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119251/#review62209 --- src/lib/kaboutdata.h

Re: Review Request 119251: Fix a conflict with KCrash where the function is declared as exported

2014-07-12 Thread Cristian Oneț
On Iulie 12, 2014, 7:26 p.m., Alex Merry wrote: src/lib/kaboutdata.h, line 38 https://git.reviewboard.kde.org/r/119251/diff/1/?file=289784#file289784line38 Normally, it goes before the return type. It presumably still works where you put it, but it looks very odd. You're right,

Re: Review Request 119251: Fix a conflict with KCrash where the function is declared as exported

2014-07-12 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119251/ --- (Updated Iulie 12, 2014, 7:30 p.m.) Review request for KDE Frameworks.

Re: Review Request 119251: Fix a conflict with KCrash where the function is declared as exported

2014-07-12 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119251/ --- (Updated Iulie 12, 2014, 7:30 p.m.) Review request for KDE Frameworks

Re: Review Request 119251: Fix a conflict with KCrash where the function is declared as exported

2014-07-12 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119251/ --- (Updated July 12, 2014, 7:49 p.m.) Status -- This change has been