Re: Review Request 119300: extra-cmake-modules: Fix using the same variable for camelCase and REQUIRED_HEADERS causes problems.

2014-07-17 Thread Andreas Xavier
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119300/ --- (Updated July 17, 2014, 9:40 a.m.) Status -- This change has been

Review Request 119300: extra-cmake-modules: Fix using the same variable for camelCase and REQUIRED_HEADERS causes problems.

2014-07-15 Thread Andreas Xavier
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119300/ --- Review request for KDE Frameworks, Alex Merry and Michael Pyne.

Re: Review Request 119300: extra-cmake-modules: Fix using the same variable for camelCase and REQUIRED_HEADERS causes problems.

2014-07-15 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119300/#review62408 --- I don't think this should be necessary. Let's keep discussion

Re: Review Request 119300: extra-cmake-modules: Fix using the same variable for camelCase and REQUIRED_HEADERS causes problems.

2014-07-15 Thread Andreas Xavier
On July 15, 2014, 6:27 p.m., Alex Merry wrote: modules/ECMGenerateHeaders.cmake, line 150 https://git.reviewboard.kde.org/r/119300/diff/1/?file=290331#file290331line150 This test doesn't do what you think it does. Rather than comparing ${camelcase_headers_var} with