Review Request 119337: Wait for KMainWindow size restoring before auto saving the size

2014-07-17 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119337/ --- Review request for KDE Frameworks. Repository: kxmlgui Description

Re: Review Request 119337: Wait for KMainWindow size restoring before auto saving the size

2014-07-17 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119337/#review62576 --- would it be possible to add a unit test for it? I know it's no

Re: Review Request 119337: Wait for KMainWindow size restoring before auto saving the size

2014-07-17 Thread Martin Klapetek
> On July 17, 2014, 3:42 p.m., Martin Gräßlin wrote: > > would it be possible to add a unit test for it? I know it's not easy as it > > depends on the window manager, but Openbox which is used on the CI system > > is quite decent. I may try - Martin

Re: Review Request 119337: Wait for KMainWindow size restoring before auto saving the size

2014-07-17 Thread Christoph Feck
> On July 17, 2014, 1:42 p.m., Martin Gräßlin wrote: > > would it be possible to add a unit test for it? I know it's not easy as it > > depends on the window manager, but Openbox which is used on the CI system > > is quite decent. > > Martin Klapetek wrote: > I may try Please add/close bu

Re: Review Request 119337: Wait for KMainWindow size restoring before auto saving the size

2014-07-17 Thread Martin Klapetek
> On July 17, 2014, 3:42 p.m., Martin Gräßlin wrote: > > would it be possible to add a unit test for it? I know it's not easy as it > > depends on the window manager, but Openbox which is used on the CI system > > is quite decent. > > Martin Klapetek wrote: > I may try > > Christoph Feck

Re: Review Request 119337: Wait for KMainWindow size restoring before auto saving the size

2014-08-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119337/#review63736 --- This patch sounds wrong (at first sight) because, well, this c

Re: Review Request 119337: Wait for KMainWindow size restoring before auto saving the size

2015-01-20 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119337/ --- (Updated Jan. 20, 2015, 4:46 p.m.) Status -- This change has been di