Review Request 119563: Ship plasma_workspace.notifyrc with frameworkintegration

2014-08-01 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119563/ --- Review request for KDE Frameworks and Harald Sitter. Repository: framewor

Re: Review Request 119563: Ship plasma_workspace.notifyrc with frameworkintegration

2014-08-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119563/#review63634 --- Well, you only get the frameworks integration when you're runn

Re: Review Request 119563: Ship plasma_workspace.notifyrc with frameworkintegration

2014-08-01 Thread Martin Klapetek
> On Aug. 1, 2014, 4:31 p.m., Aleix Pol Gonzalez wrote: > > Well, you only get the frameworks integration when you're running Plasma > > 5... > > > > Actually, frameworksintegration should move to kde/workspace at least. It's > > not a framework. Well the message boxes won't do any sounds wit

Re: Review Request 119563: Ship plasma_workspace.notifyrc with frameworkintegration

2014-08-01 Thread Aleix Pol Gonzalez
> On Aug. 1, 2014, 2:31 p.m., Aleix Pol Gonzalez wrote: > > Well, you only get the frameworks integration when you're running Plasma > > 5... > > > > Actually, frameworksintegration should move to kde/workspace at least. It's > > not a framework. > > Martin Klapetek wrote: > Well the mess

Re: Review Request 119563: Ship plasma_workspace.notifyrc with frameworkintegration

2014-08-01 Thread Martin Klapetek
> On Aug. 1, 2014, 4:31 p.m., Aleix Pol Gonzalez wrote: > > Well, you only get the frameworks integration when you're running Plasma > > 5... > > > > Actually, frameworksintegration should move to kde/workspace at least. It's > > not a framework. > > Martin Klapetek wrote: > Well the mess

Re: Review Request 119563: Ship plasma_workspace.notifyrc with frameworkintegration

2014-08-01 Thread Harald Sitter
> On Aug. 1, 2014, 2:31 p.m., Aleix Pol Gonzalez wrote: > > Well, you only get the frameworks integration when you're running Plasma > > 5... > > > > Actually, frameworksintegration should move to kde/workspace at least. It's > > not a framework. > > Martin Klapetek wrote: > Well the mess

Re: Review Request 119563: Ship plasma_workspace.notifyrc with frameworkintegration

2014-08-20 Thread Martin Klapetek
> On Aug. 1, 2014, 4:31 p.m., Aleix Pol Gonzalez wrote: > > Well, you only get the frameworks integration when you're running Plasma > > 5... > > > > Actually, frameworksintegration should move to kde/workspace at least. It's > > not a framework. > > Martin Klapetek wrote: > Well the mess

Re: Review Request 119563: Ship plasma_workspace.notifyrc with frameworkintegration

2014-08-22 Thread Martin Klapetek
> On Aug. 1, 2014, 4:31 p.m., Aleix Pol Gonzalez wrote: > > Well, you only get the frameworks integration when you're running Plasma > > 5... > > > > Actually, frameworksintegration should move to kde/workspace at least. It's > > not a framework. > > Martin Klapetek wrote: > Well the mess

Re: Review Request 119563: Ship plasma_workspace.notifyrc with frameworkintegration

2014-08-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119563/#review65040 --- Ship it! Ship It! - David Edmundson On Aug. 1, 2014, 2:29

Re: Review Request 119563: Ship plasma_workspace.notifyrc with frameworkintegration

2014-08-25 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119563/ --- (Updated Aug. 25, 2014, 7:38 a.m.) Status -- This change has been ma