Re: Review Request 119879: call style()->drawControl rather than drawItemText to handle button painting in kmultitabbar

2014-08-21 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119879/ --- (Updated Aug. 21, 2014, 1:02 p.m.) Status -- This change has been ma

Re: Review Request 119879: call style()->drawControl rather than drawItemText to handle button painting in kmultitabbar

2014-08-21 Thread Hugo Pereira Da Costa
> On Aug. 21, 2014, 10:42 a.m., Christoph Feck wrote: > > Regarding rotating the complete button, I doubt that it will look good. You > > will also rotate lightning/shadows, direction of gradients etc. yes, right ... in fact, what my own code does (after double checking), is call CE_ToolButto

Re: Review Request 119879: call style()->drawControl rather than drawItemText to handle button painting in kmultitabbar

2014-08-21 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119879/#review64971 --- Ship it! Regarding rotating the complete button, I doubt that

Review Request 119879: call style()->drawControl rather than drawItemText to handle button painting in kmultitabbar

2014-08-21 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119879/ --- Review request for KDE Frameworks, Christoph Feck, Gilles Caulier, and Mark