---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/
---
(Updated Sept. 3, 2014, 12:38 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/#review65702
---
Ship it!
I think it looks good, let's get this in.
- Aleix
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/#review65740
---
Ship it!
Ship It!
- Alex Merry
On Sept. 1, 2014, 10:24
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/
---
(Updated Sept. 1, 2014, 3:54 p.m.)
Review request for Build System and
On Aug. 27, 2014, 6:05 p.m., Alex Merry wrote:
modules/ECMQueryQmake.cmake, line 1
https://git.reviewboard.kde.org/r/119901/diff/6/?file=307834#file307834line1
I think we need to be a bit more clever here. I'd go for a cache
variable, and if (TARGET Qt5::qmake), set the default
On Aug. 27, 2014, 6:05 p.m., Alex Merry wrote:
modules/ECMQueryQmake.cmake, line 2
https://git.reviewboard.kde.org/r/119901/diff/6/?file=307834#file307834line2
CMake macros/functions that take a variable name usually take it first.
Swapping the argument order would make it more
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/
---
(Updated Aug. 27, 2014, 6:41 p.m.)
Review request for Build System and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/#review65382
---
Nice! See my comments below, though.
On Aug. 23, 2014, 1:16 a.m., David Faure wrote:
Is this going to lead to make install installing plugins into $QTDIR
rather than into $CMAKE_INSTALL_PREFIX? This is a big no-no by default. For
a developer, the path returned by qmake might not even be writable
(/usr/...).
QCA has
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/
---
(Updated Aug. 25, 2014, 9:14 p.m.)
Review request for Build System and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/#review65234
---
kde-modules/KDEInstallDirs.cmake
On Aug. 25, 2014, 10:32 p.m., David Faure wrote:
kde-modules/KDEInstallDirs.cmake, line 340
https://git.reviewboard.kde.org/r/119901/diff/2/?file=307587#file307587line340
I'd name that ECM_INSTALL_PLUGINS_IN_QT_DIR to be clearer about what
it's about.
Is this line
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/
---
(Updated Aug. 25, 2014, 10:47 p.m.)
Review request for Build System and
On Aug. 25, 2014, 5:02 p.m., David Faure wrote:
kde-modules/KDEInstallDirs.cmake, line 340
https://git.reviewboard.kde.org/r/119901/diff/2/?file=307587#file307587line340
I'd name that ECM_INSTALL_PLUGINS_IN_QT_DIR to be clearer about what
it's about.
Is this line
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/
---
(Updated Aug. 25, 2014, 11:30 p.m.)
Review request for Build System and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/
---
(Updated Aug. 25, 2014, 11:23 p.m.)
Review request for Build System and
On Aug. 25, 2014, 10:32 p.m., David Faure wrote:
kde-modules/KDEInstallDirs.cmake, line 340
https://git.reviewboard.kde.org/r/119901/diff/2/?file=307587#file307587line340
I'd name that ECM_INSTALL_PLUGINS_IN_QT_DIR to be clearer about what
it's about.
Is this line
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/#review65242
---
Ship it!
LOL just when the naming started to make sense, you
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/#review65255
---
kde-modules/KDEInstallDirs.cmake
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/
---
Review request for Build System and KDE Frameworks.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/#review65037
---
Looks good. THere is a couple of things that is kind of a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/#review65074
---
Is this going to lead to make install installing plugins into
22 matches
Mail list logo
