Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120198/ --- (Updated Nov. 11, 2014, 11:20 a.m.) Status -- This change has been m

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

> On Nov. 10, 2014, 9:57 p.m., David Faure wrote: > > src/services/kplugininfo.cpp, line 47 > > > > > > Missing "static" before inline, if these methods are only used in this > > .cpp file. > > Alexander Richard

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

> On Nov. 10, 2014, 9:57 nachm., David Faure wrote: > > src/services/kplugininfo.cpp, line 47 > > > > > > Missing "static" before inline, if these methods are only used in this > > .cpp file. I put it all in an

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120198/#review70220 --- Ship it! src/services/kplugininfo.cpp

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120198/ --- (Updated Nov. 7, 2014, 5:38 nachm.) Review request for KDE Frameworks.

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120198/#review69947 --- src/services/kplugininfo.cpp

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120198/ --- (Updated Nov. 6, 2014, 6:50 nachm.) Review request for KDE Frameworks.

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120198/#review69928 --- src/services/kplugininfo.cpp

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

> On Okt. 21, 2014, 11:19 nachm., Sebastian Kügler wrote: > > I've looked at the patch and tested it, it looks like a really useful > > improvement, and one more step of untangling the plugin / metadata > > situation from KService/KSycoca. I don't feel comfortable enough hitting > > ship it, b

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120198/#review68857 --- I've looked at the patch and tested it, it looks like a really

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

> On Sept. 22, 2014, 11:08 nachm., David Faure wrote: > > We already have old JSON and new JSON? Now I am indeed completely lost with > > this stuff. Seems application developers are, too, given the questions I > > got during Akademy. We (= the set of people who understand this stuff) need > >

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120198/#review67234 --- We already have old JSON and new JSON? Now I am indeed complet

Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120198/ --- Review request for KDE Frameworks. Repository: kservice Description ---