Re: Review Request 120217: KWindowInfo::state can map urgency to NET::DemandsAttention

2014-09-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120217/ --- (Updated Sept. 16, 2014, 9:48 a.m.) Status -- This change has been d

Re: Review Request 120217: KWindowInfo::state can map urgency to NET::DemandsAttention

2014-09-16 Thread Martin Gräßlin
> On Sept. 16, 2014, 12:28 a.m., Thomas Lübking wrote: > > If we merge, we should imo merge in NetWinInfo - having the same function > > return different values in NetWinInfo and KWindowInfo feels wrong. > > Martin Gräßlin wrote: > I considered it, but decided against it as I consider NETWi

Re: Review Request 120217: KWindowInfo::state can map urgency to NET::DemandsAttention

2014-09-15 Thread Thomas Lübking
> On Sept. 15, 2014, 10:28 nachm., Thomas Lübking wrote: > > If we merge, we should imo merge in NetWinInfo - having the same function > > return different values in NetWinInfo and KWindowInfo feels wrong. > > Martin Gräßlin wrote: > I considered it, but decided against it as I consider NET

Re: Review Request 120217: KWindowInfo::state can map urgency to NET::DemandsAttention

2014-09-15 Thread Martin Gräßlin
> On Sept. 16, 2014, 12:28 a.m., Thomas Lübking wrote: > > If we merge, we should imo merge in NetWinInfo - having the same function > > return different values in NetWinInfo and KWindowInfo feels wrong. > > Martin Gräßlin wrote: > I considered it, but decided against it as I consider NETWi

Re: Review Request 120217: KWindowInfo::state can map urgency to NET::DemandsAttention

2014-09-15 Thread Thomas Lübking
> On Sept. 15, 2014, 10:28 nachm., Thomas Lübking wrote: > > If we merge, we should imo merge in NetWinInfo - having the same function > > return different values in NetWinInfo and KWindowInfo feels wrong. > > Martin Gräßlin wrote: > I considered it, but decided against it as I consider NET

Re: Review Request 120217: KWindowInfo::state can map urgency to NET::DemandsAttention

2014-09-15 Thread Martin Gräßlin
> On Sept. 16, 2014, 12:28 a.m., Thomas Lübking wrote: > > If we merge, we should imo merge in NetWinInfo - having the same function > > return different values in NetWinInfo and KWindowInfo feels wrong. I considered it, but decided against it as I consider NETWinInfo to be a level lower to X

Re: Review Request 120217: KWindowInfo::state can map urgency to NET::DemandsAttention

2014-09-15 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120217/#review66618 --- If we merge, we should imo merge in NetWinInfo - having the sa

Review Request 120217: KWindowInfo::state can map urgency to NET::DemandsAttention

2014-09-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120217/ --- Review request for KDE Frameworks and kwin. Repository: kwindowsystem D