Review Request 120519: Don't call 'enableTestMode' when QStandardPaths::isTestModeEnabled is false

2014-10-07 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120519/ --- Review request for KDE Frameworks and David Faure. Repository: kservice

Re: Review Request 120519: Don't call 'enableTestMode' when QStandardPaths::isTestModeEnabled is false

2014-10-07 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120519/#review68047 --- Looks good, I'd like someone giving it a second look though

Re: Review Request 120519: Don't call 'enableTestMode' when QStandardPaths::isTestModeEnabled is false

2014-10-07 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120519/ --- (Updated Oct. 7, 2014, 2:22 p.m.) Review request for KDE Frameworks and D

Re: Review Request 120519: Don't call 'enableTestMode' when QStandardPaths::isTestModeEnabled is false

2014-10-08 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120519/#review68091 --- Ship it! Seems sensible to me - Lukáš Tinkl On Říj. 7, 201

Re: Review Request 120519: Don't call 'enableTestMode' when QStandardPaths::isTestModeEnabled is false

2014-10-08 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120519/ --- (Updated Oct. 8, 2014, 8:13 p.m.) Status -- This change has been mar