Re: Review Request 121317: Add JSON metadata to the kded modules

2015-03-03 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121317/ --- (Updated March 3, 2015, 7:31 p.m.) Status -- This change has been ma

Re: Review Request 121317: Add JSON metadata to the kded modules

2015-02-28 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121317/#review76764 --- Ship it! Ship It! - Sebastian Kügler On Feb. 27, 2015, 11:

Re: Review Request 121317: Add JSON metadata to the kded modules

2015-02-28 Thread Sebastian Kügler
> On Dec. 1, 2014, 4:59 p.m., Aleix Pol Gonzalez wrote: > > Have you checked if the "Background Services" kded still works after this? > > Aleix Pol Gonzalez wrote: > Sorry, I meant KCM. > > Alex Richardson wrote: > `grep -irn "background" /kf5-install/share/kservices5/kded` does not gi

Re: Review Request 121317: Add JSON metadata to the kded modules

2015-02-27 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121317/ --- (Updated Feb. 27, 2015, 11:35 p.m.) Review request for KDE Frameworks, Da

Re: Review Request 121317: Add JSON metadata to the kded modules

2015-02-27 Thread David Faure
> On Feb. 27, 2015, 7:41 a.m., David Faure wrote: > > Oops, what happened here? Did I forget to review this? Having json metadata > > for all kded modules sounds like a great idea (especially since kiod > > requires that, so if some move later to kiod, it will have to be done). > > Alex Richar

Re: Review Request 121317: Add JSON metadata to the kded modules

2015-02-27 Thread Alex Richardson
> On Feb. 27, 2015, 7:41 a.m., David Faure wrote: > > Oops, what happened here? Did I forget to review this? Having json metadata > > for all kded modules sounds like a great idea (especially since kiod > > requires that, so if some move later to kiod, it will have to be done). I thought this

Re: Review Request 121317: Add JSON metadata to the kded modules

2015-02-26 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121317/#review76698 --- Oops, what happened here? Did I forget to review this? Having

Re: Review Request 121317: Add JSON metadata to the kded modules

2015-02-26 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121317/ --- (Updated Feb. 26, 2015, 6:53 nachm.) Status -- This change has been

Re: Review Request 121317: Add JSON metadata to the kded modules

2014-12-01 Thread Aleix Pol Gonzalez
> On Dec. 1, 2014, 4:59 p.m., Aleix Pol Gonzalez wrote: > > Have you checked if the "Background Services" kded still works after this? > > Aleix Pol Gonzalez wrote: > Sorry, I meant KCM. > > Alexander Richardson wrote: > `grep -irn "background" /kf5-install/share/kservices5/kded` does n

Re: Review Request 121317: Add JSON metadata to the kded modules

2014-12-01 Thread Alexander Richardson
> On Dez. 1, 2014, 4:59 nachm., Aleix Pol Gonzalez wrote: > > Have you checked if the "Background Services" kded still works after this? > > Aleix Pol Gonzalez wrote: > Sorry, I meant KCM. `grep -irn "background" /kf5-install/share/kservices5/kded` does not give any results for me, where c

Re: Review Request 121317: Add JSON metadata to the kded modules

2014-12-01 Thread Aleix Pol Gonzalez
> On Dec. 1, 2014, 4:59 p.m., Aleix Pol Gonzalez wrote: > > Have you checked if the "Background Services" kded still works after this? Sorry, I meant KCM. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://g

Re: Review Request 121317: Add JSON metadata to the kded modules

2014-12-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121317/#review71202 --- Have you checked if the "Background Services" kded still works

Review Request 121317: Add JSON metadata to the kded modules

2014-12-01 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121317/ --- Review request for KDE Frameworks, David Faure and Sebastian Kügler. Repo