Re: Review Request 121411: Don't trigger animation if size changed.

2014-12-11 Thread David Edmundson
> On Dec. 9, 2014, 6:11 p.m., Kai Uwe Broulik wrote: > > Wasn't that part of the idea? Having it scale up the pixmap first when > > resizing and then re-rendering it later? > > Xuetian Weng wrote: > 1. icon size (the widget size) doesn't change frequently. Usually it only > happens when us

Re: Review Request 121411: Don't trigger animation if size changed.

2014-12-11 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121411/ --- (Updated Dec. 11, 2014, 7:49 p.m.) Status -- This change has been ma

Re: Review Request 121411: Don't trigger animation if size changed.

2014-12-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121411/#review71784 --- Ship it! Ship It! - Marco Martin On Dec. 11, 2014, 3:55 a.

Re: Review Request 121411: Don't trigger animation if size changed.

2014-12-10 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121411/ --- (Updated Dec. 11, 2014, 3:55 a.m.) Review request for KDE Frameworks, Pla

Re: Review Request 121411: Don't trigger animation if size changed.

2014-12-10 Thread Xuetian Weng
> On Dec. 9, 2014, 6:11 p.m., Kai Uwe Broulik wrote: > > Wasn't that part of the idea? Having it scale up the pixmap first when > > resizing and then re-rendering it later? > > Xuetian Weng wrote: > 1. icon size (the widget size) doesn't change frequently. Usually it only > happens when us

Re: Review Request 121411: Don't trigger animation if size changed.

2014-12-10 Thread David Edmundson
> On Dec. 9, 2014, 6:11 p.m., Kai Uwe Broulik wrote: > > Wasn't that part of the idea? Having it scale up the pixmap first when > > resizing and then re-rendering it later? > > Xuetian Weng wrote: > 1. icon size (the widget size) doesn't change frequently. Usually it only > happens when us

Re: Review Request 121411: Don't trigger animation if size changed.

2014-12-10 Thread Xuetian Weng
> On Dec. 9, 2014, 6:11 p.m., Kai Uwe Broulik wrote: > > Wasn't that part of the idea? Having it scale up the pixmap first when > > resizing and then re-rendering it later? > > Xuetian Weng wrote: > 1. icon size (the widget size) doesn't change frequently. Usually it only > happens when us

Re: Review Request 121411: Don't trigger animation if size changed.

2014-12-10 Thread Sebastian Kügler
> On Dec. 9, 2014, 6:11 p.m., Kai Uwe Broulik wrote: > > Wasn't that part of the idea? Having it scale up the pixmap first when > > resizing and then re-rendering it later? > > Xuetian Weng wrote: > 1. icon size (the widget size) doesn't change frequently. Usually it only > happens when us

Re: Review Request 121411: Don't trigger animation if size changed.

2014-12-10 Thread David Edmundson
> On Dec. 9, 2014, 6:11 p.m., Kai Uwe Broulik wrote: > > Wasn't that part of the idea? Having it scale up the pixmap first when > > resizing and then re-rendering it later? > > Xuetian Weng wrote: > 1. icon size (the widget size) doesn't change frequently. Usually it only > happens when us

Re: Review Request 121411: Don't trigger animation if size changed.

2014-12-09 Thread Xuetian Weng
> On Dec. 9, 2014, 6:11 p.m., Kai Uwe Broulik wrote: > > Wasn't that part of the idea? Having it scale up the pixmap first when > > resizing and then re-rendering it later? 1. icon size (the widget size) doesn't change frequently. Usually it only happens when user resize the UI or changes the

Re: Review Request 121411: Don't trigger animation if size changed.

2014-12-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121411/#review71665 --- Wasn't that part of the idea? Having it scale up the pixmap fi

Review Request 121411: Don't trigger animation if size changed.

2014-12-09 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121411/ --- Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Kai Uwe