Re: Review Request 121575: FindEpoxy.cmake

2016-03-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121575/ --- (Updated March 15, 2016, 10:47 a.m.) Status -- This change has been

Re: Review Request 121575: FindEpoxy.cmake

2014-12-18 Thread Jan Kundrát
On Dec. 18, 2014, 8:47 a.m., Martin Gräßlin wrote: find-modules/Findepoxy.cmake, line 14 https://git.reviewboard.kde.org/r/121575/diff/1/?file=333638#file333638line14 I just need to point out that I consider epoxy as a bad dependency for usage in a cross platform library (like

Re: Review Request 121575: FindEpoxy.cmake

2014-12-18 Thread Marco Martin
On Dec. 18, 2014, 8:47 a.m., Martin Gräßlin wrote: find-modules/Findepoxy.cmake, line 14 https://git.reviewboard.kde.org/r/121575/diff/1/?file=333638#file333638line14 I just need to point out that I consider epoxy as a bad dependency for usage in a cross platform library (like

Re: Review Request 121575: FindEpoxy.cmake

2014-12-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121575/ --- (Updated Dec. 18, 2014, 3:37 p.m.) Review request for KDE Frameworks,

Re: Review Request 121575: FindEpoxy.cmake

2014-12-18 Thread Fredrik Höglund
On Dec. 18, 2014, 8:47 a.m., Martin Gräßlin wrote: find-modules/Findepoxy.cmake, line 14 https://git.reviewboard.kde.org/r/121575/diff/1/?file=333638#file333638line14 I just need to point out that I consider epoxy as a bad dependency for usage in a cross platform library (like

Review Request 121575: FindEpoxy.cmake

2014-12-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121575/ --- Review request for KDE Frameworks, kwin and Martin Gräßlin. Repository: