Re: Review Request 121773: Fix build without X.

2015-01-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121773/#review72897 --- Ship it! Ship It! - Martin Gräßlin On Dec. 31, 2014,

Re: Review Request 121773: Fix build without X.

2015-01-02 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121773/ --- (Updated Jan. 2, 2015, 2:03 p.m.) Status -- This change has been

Review Request 121773: Fix build without X.

2014-12-31 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121773/ --- Review request for KDE Frameworks. Repository: kdesu Description

Re: Review Request 121773: Fix build without X.

2014-12-31 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121773/#review72841 --- src/kdesud/kdesud.cpp

Re: Review Request 121773: Fix build without X.

2014-12-31 Thread Michael Palimaka
On Dec. 31, 2014, 12:52 p.m., Jeremy Whiting wrote: src/kdesud/kdesud.cpp, line 76 https://git.reviewboard.kde.org/r/121773/diff/1/?file=337535#file337535line76 Why not use if HAVE_X11 !defined(Q_OS_MAC) to keep that fix in place? !defined(Q_OS_MAC) was only added after the

Re: Review Request 121773: Fix build without X.

2014-12-31 Thread Jeremy Whiting
On Dec. 31, 2014, 5:52 a.m., Jeremy Whiting wrote: src/kdesud/kdesud.cpp, line 76 https://git.reviewboard.kde.org/r/121773/diff/1/?file=337535#file337535line76 Why not use if HAVE_X11 !defined(Q_OS_MAC) to keep that fix in place? Michael Palimaka wrote: !defined(Q_OS_MAC)