Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-21 Thread Hugo Pereira Da Costa
On Jan. 20, 2015, 4:16 p.m., David Faure wrote: src/kcmoduleproxy.cpp, line 99 https://git.reviewboard.kde.org/r/122168/diff/1/?file=343470#file343470line99 ... while this line is happy with dots. Hugo Pereira Da Costa wrote: ok. Got it now. Thanks ! Hugo Pereira Da Costa

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-21 Thread David Faure
On Jan. 20, 2015, 4:16 p.m., David Faure wrote: src/kcmoduleproxy.cpp, line 99 https://git.reviewboard.kde.org/r/122168/diff/1/?file=343470#file343470line99 ... while this line is happy with dots. Hugo Pereira Da Costa wrote: ok. Got it now. Thanks ! Hugo Pereira Da Costa

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-21 Thread Hugo Pereira Da Costa
On Jan. 20, 2015, 4:16 p.m., David Faure wrote: src/kcmoduleproxy.cpp, line 99 https://git.reviewboard.kde.org/r/122168/diff/1/?file=343470#file343470line99 ... while this line is happy with dots. Hugo Pereira Da Costa wrote: ok. Got it now. Thanks ! Hugo Pereira Da Costa

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-21 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122168/ --- (Updated Jan. 21, 2015, 10:57 a.m.) Review request for KDE Frameworks.

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-21 Thread Hugo Pereira Da Costa
On Jan. 20, 2015, 4:16 p.m., David Faure wrote: src/kcmoduleproxy.cpp, line 99 https://git.reviewboard.kde.org/r/122168/diff/1/?file=343470#file343470line99 ... while this line is happy with dots. Hugo Pereira Da Costa wrote: ok. Got it now. Thanks ! Hugo Pereira Da Costa

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-21 Thread Hugo Pereira Da Costa
On Jan. 20, 2015, 4:16 p.m., David Faure wrote: src/kcmoduleproxy.cpp, line 99 https://git.reviewboard.kde.org/r/122168/diff/1/?file=343470#file343470line99 ... while this line is happy with dots. Hugo Pereira Da Costa wrote: ok. Got it now. Thanks ! Stupid question: does

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-21 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122168/ --- (Updated Jan. 21, 2015, 12:38 p.m.) Status -- This change has been

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122168/#review74471 --- Ship it! Ship It! - David Faure On Jan. 21, 2015, 10:57

Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-20 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122168/ --- Review request for KDE Frameworks. Repository: kcmutils Description

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122168/#review74403 --- src/kcmoduleproxy.cpp

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-20 Thread Hugo Pereira Da Costa
On Jan. 20, 2015, 4:16 p.m., David Faure wrote: src/kcmoduleproxy.cpp, line 99 https://git.reviewboard.kde.org/r/122168/diff/1/?file=343470#file343470line99 ... while this line is happy with dots. ok. Got it now. Thanks ! - Hugo

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-20 Thread Hugo Pereira Da Costa
On Jan. 20, 2015, 3:52 p.m., David Faure wrote: for the path yes, but there is no reason to remove that from the service name mmm. Maybe I am confused with the comment. Still, I just checked that passing X-KDE-Library=kstyle_breeze_config.so in the kcmodule .desktop also crashes dbus

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122168/#review74399 --- for the path yes, but there is no reason to remove that from

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-20 Thread Hugo Pereira Da Costa
On Jan. 20, 2015, 3:52 p.m., David Faure wrote: for the path yes, but there is no reason to remove that from the service name Hugo Pereira Da Costa wrote: mmm. Maybe I am confused with the comment. Still, I just checked that passing X-KDE-Library=kstyle_breeze_config.so