Re: Review Request 122459: sync the bookmarkmanager with the shared one only if change was from this process

2015-02-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122459/ --- (Updated Feb. 9, 2015, 5:22 p.m.) Status -- This change has been mar

Re: Review Request 122459: sync the bookmarkmanager with the shared one only if change was from this process

2015-02-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122459/#review75596 --- Ship it! I don't know this code very well, but the reasoning

Re: Review Request 122459: sync the bookmarkmanager with the shared one only if change was from this process

2015-02-06 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122459/ --- (Updated Feb. 6, 2015, 5:53 p.m.) Review request for KDE Frameworks. Bu

Re: Review Request 122459: sync the bookmarkmanager with the shared one only if change was from this process

2015-02-06 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122459/#review75541 --- src/filewidgets/kfileplacesmodel.cpp

Review Request 122459: sync the bookmarkmanager with the shared one only if change was from this process

2015-02-06 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122459/ --- Review request for KDE Frameworks. Bugs: 343735 https://bugs.kde.org/