---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122542/
---
(Updated Feb. 13, 2015, 12:40 p.m.)
Status
--
This change has been
On feb. 12, 2015, 4:43 p.m., Albert Astals Cid wrote:
It also adds a Q_DECL_OVERRIDE to a Q_DECL_FINAL which is not needed since
final will already complain if trying to finalize something that is not
overriding a virtual of the parent, no?
Kevin Funk wrote:
Nitpicker! :D
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122542/#review75956
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Feb. 12, 2015,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122542/
---
Review request for KDE Frameworks.
Description
---
This is a huge
On Feb. 12, 2015, 2:53 p.m., Albert Astals Cid wrote:
Is your script smart enough to convert
virtual QByteArray data() const;
into
QByteArray data() const Q_DECL_OVERRIDE;
instead of
virtual QByteArray data() const Q_DECL_OVERRIDE;
Nope. It only deals with
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122542/#review75926
---
+1 from me (though it would be prettier to also remove
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122542/
---
(Updated Feb. 12, 2015, 3:47 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122542/#review75928
---
It also adds a Q_DECL_OVERRIDE to a Q_DECL_FINAL which is not
On Feb. 12, 2015, 4:43 p.m., Albert Astals Cid wrote:
It also adds a Q_DECL_OVERRIDE to a Q_DECL_FINAL which is not needed since
final will already complain if trying to finalize something that is not
overriding a virtual of the parent, no?
Nitpicker! :D
Fixed that one occurence, but
