---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122576/#review77316
---
Moved to knewstuff: https://git.reviewboard.kde.org/r/122910/
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122576/
---
(Updated March 11, 2015, 11:08 p.m.)
Status
--
This change has been
On March 7, 2015, 9:04 a.m., David Faure wrote:
KService is basically ksycoca. One day I hope we can move away from that,
which means all of kservice could then be deprecated.
So it still makes sense to *use* kservice where looking up desktop files is
needed (it's our current
On March 7, 2015, 9:04 a.m., David Faure wrote:
KService is basically ksycoca. One day I hope we can move away from that,
which means all of kservice could then be deprecated.
So it still makes sense to *use* kservice where looking up desktop files is
needed (it's our current
On March 7, 2015, 9:04 a.m., David Faure wrote:
KService is basically ksycoca. One day I hope we can move away from that,
which means all of kservice could then be deprecated.
So it still makes sense to *use* kservice where looking up desktop files is
needed (it's our current
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122576/#review77147
---
KService is basically ksycoca. One day I hope we can move
On Feb. 16, 2015, 11:12 a.m., Aleix Pol Gonzalez wrote:
src/CMakeLists.txt, line 81
https://git.reviewboard.kde.org/r/122576/diff/1/?file=349785#file349785line81
I don't think this class is enough reason to make KService depend on
QtWidgets.
I think so, too. Any other idea?
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122576/
---
(Updated March 1, 2015, 10:59 a.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122576/
---
(Updated March 1, 2015, 2:28 p.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122576/#review76422
---
src/kmoretools/kmoretoolsconfigdialog.h
On Feb. 22, 2015, 1:52 p.m., Albert Astals Cid wrote:
src/kmoretools/kmoretoolsconfigdialog.h, line 27
https://git.reviewboard.kde.org/r/122576/diff/4/?file=350011#file350011line27
Why is a non private header including a private header?
kmoretoolsconfigdialog.h should be private,
On feb. 22, 2015, 1:52 p.m., Albert Astals Cid wrote:
src/kmoretools/kmoretoolsconfigdialog.h, line 27
https://git.reviewboard.kde.org/r/122576/diff/4/?file=350011#file350011line27
Why is a non private header including a private header?
Gregor Mi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122576/
---
(Updated Feb. 22, 2015, 8:34 p.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122576/
---
(Updated Feb. 22, 2015, 11:24 p.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122576/
---
(Updated Feb. 16, 2015, 10:30 p.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122576/
---
(Updated Feb. 16, 2015, 10:36 p.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122576/
---
(Updated Feb. 16, 2015, 11:05 p.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122576/#review76158
---
You're missing lots of const in your getters and const in
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122576/#review76114
---
src/CMakeLists.txt
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122576/
---
Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta.
20 matches
Mail list logo