Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- (Updated March 4, 2015, 10:51 a.m.) Status -- This change has been m

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/#review76991 --- Ship it! Looking good. src/kdeclarative/qmlobject.h

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/#review76989 --- +1 - David Edmundson On March 3, 2015, 7:29 p.m., Marco Mar

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

> On March 3, 2015, 5:46 p.m., David Edmundson wrote: > > src/kpackagelauncherqml/main.cpp, line 80 > > > > > > we load this, we set the authors then don't do anything with it? > > > > Is it used implicit

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- (Updated March 3, 2015, 7:29 p.m.) Review request for KDE Frameworks and

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

> On March 3, 2015, 5:46 p.m., David Edmundson wrote: > > src/kpackagelauncherqml/main.cpp, line 80 > > > > > > we load this, we set the authors then don't do anything with it? > > > > Is it used implicit

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

> On March 3, 2015, 5:46 p.m., David Edmundson wrote: > > src/kpackagelauncherqml/main.cpp, line 99 > > > > > > returning here is weird. ah, you do it because otherwise the QQuickWindow would be out of scope. -

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

> On March 3, 2015, 5:46 p.m., David Edmundson wrote: > > src/kdeclarative/qmlobject.cpp, line 199 > > > > > > question, where does > > > > KPackage/GenericQML come from? it's an internal type in kpack

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- (Updated March 3, 2015, 6:10 p.m.) Review request for KDE Frameworks and

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/#review76958 --- src/kdeclarative/qmlobject.h

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- (Updated March 3, 2015, 10:14 a.m.) Review request for KDE Frameworks and

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

On Feb. 23, 2015, 11:08 a.m., Marco Martin wrote: > > I like where this is going! :) > > Marco Martin wrote: > One thing i'm still not sure is what to export to it. it now sets the > application commandline arguments, that's not really possible to obtain > otherwise. > Another thing wo

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

On Feb. 23, 2015, 12:08 p.m., Marco Martin wrote: > > I like where this is going! :) > > Marco Martin wrote: > One thing i'm still not sure is what to export to it. it now sets the > application commandline arguments, that's not really possible to obtain > otherwise. > Another thing wo

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

> On Feb. 23, 2015, 11:08 a.m., Aleix Pol Gonzalez wrote: > > src/qmlpackagelauncher/CMakeLists.txt, line 8 > > > > > > Maybe it would make sense to call it "kpackagelauncher-qml"? renamed, but without the dash th

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- (Updated Feb. 25, 2015, 9:29 a.m.) Review request for KDE Frameworks and

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/#review76459 --- src/qmlpackagelauncher/CMakeLists.txt

Review Request 122667: Some tools for easily do qml based apps using KPackage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative