Re: Review Request 122755: Add testcases for KIO::del()

> On March 7, 2015, 10:22 a.m., Emmanuel Pescosta wrote: > > autotests/deletejobtest.cpp, line 62 > > > > > > This has broken the KIO build > > (http://build.kde.org/job/kio_stable_qt5/123/console) > > > >

Re: Review Request 122755: Add testcases for KIO::del()

> On March 7, 2015, 10:22 a.m., Emmanuel Pescosta wrote: > > autotests/deletejobtest.cpp, line 62 > > > > > > This has broken the KIO build > > (http://build.kde.org/job/kio_stable_qt5/123/console) > > > >

Re: Review Request 122755: Add testcases for KIO::del()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122755/#review77157 --- autotests/deletejobtest.cpp

Re: Review Request 122755: Add testcases for KIO::del()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122755/ --- (Updated March 6, 2015, 9:57 p.m.) Status -- This change has been ma

Re: Review Request 122755: Add testcases for KIO::del()

> On March 1, 2015, 2:34 a.m., Aleix Pol Gonzalez wrote: > > autotests/deletejobtest.cpp, line 43 > > > > > > Would it be better to use the unicode escaping? This can look weird in > > some set ups? I also did t

Re: Review Request 122755: Add testcases for KIO::del()

> On Feb. 28, 2015, 7:24 p.m., Emmanuel Pescosta wrote: > > autotests/deldirtest.cpp, line 51 > > > > > > KJob::NoError instead of 0? We need a cast for that check. Maybe you can look at my solution? - Martin

Re: Review Request 122755: Add testcases for KIO::del()

> On March 1, 2015, 2:34 a.m., Aleix Pol Gonzalez wrote: > > Looks good to me, can you push yourself? I can push it myself if someone decides whether that static_cast(KJob::NoError) is fine or if 0 should be hardcoded (like in my first patch). I am fine with both - so I'd like to stick to what

Re: Review Request 122755: Add testcases for KIO::del()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122755/ --- (Updated March 1, 2015, 12:21 p.m.) Review request for KDE Frameworks.

Re: Review Request 122755: Add testcases for KIO::del()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122755/#review76790 --- Ship it! Looks good to me, can you push yourself? autotests

Re: Review Request 122755: Add testcases for KIO::del()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122755/ --- (Updated Feb. 28, 2015, 9:21 p.m.) Review request for KDE Frameworks. C

Re: Review Request 122755: Add testcases for KIO::del()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122755/#review76769 --- Thanks for the test! :) Maybe you can add some negative test

Review Request 122755: Add testcases for KIO::del()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122755/ --- Review request for KDE Frameworks. Repository: kio Description ---