Re: Review Request 122875: Fix KIconEngine::paint to handle different devicePixelRatios

2015-03-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122875/ --- (Updated March 11, 2015, 2:41 p.m.) Status -- This change has been m

Re: Review Request 122875: Fix KIconEngine::paint to handle different devicePixelRatios

2015-03-10 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122875/#review77266 --- Ship it! Ship It! - Christoph Feck On March 10, 2015, 3:42

Re: Review Request 122875: Fix KIconEngine::paint to handle different devicePixelRatios

2015-03-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122875/ --- (Updated March 10, 2015, 3:42 p.m.) Review request for KDE Frameworks and

Re: Review Request 122875: Fix KIconEngine::paint to handle different devicePixelRatios

2015-03-09 Thread Albert Astals Cid
> On mar. 9, 2015, 6:26 p.m., Albert Astals Cid wrote: > > makes no sense to me, you are getting a rect to > > paint on and painting outside of it. > > > > what even warrants that there will be "space" > > on the qpainter? > > > > should the size increase be done in upper levels? > > David Ed

Re: Review Request 122875: Fix KIconEngine::paint to handle different devicePixelRatios

2015-03-09 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122875/#review77228 --- src/kiconengine.cpp

Re: Review Request 122875: Fix KIconEngine::paint to handle different devicePixelRatios

2015-03-09 Thread David Edmundson
> On March 9, 2015, 6:26 p.m., Albert Astals Cid wrote: > > makes no sense to me, you are getting a rect to > > paint on and painting outside of it. > > > > what even warrants that there will be "space" > > on the qpainter? > > > > should the size increase be done in upper levels? It's not pa

Re: Review Request 122875: Fix KIconEngine::paint to handle different devicePixelRatios

2015-03-09 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122875/#review77223 --- makes no sense to me, you are getting a rect to paint on and

Re: Review Request 122875: Fix KIconEngine::paint to handle different devicePixelRatios

2015-03-09 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122875/#review77222 --- Hi, this fixes the pixelation issues in the Kate document list

Review Request 122875: Fix KIconEngine::paint to handle different devicePixelRatios

2015-03-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122875/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kiconth