Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/ --- Review request for KDE Frameworks, Martin Gräßlin and Thomas Lübking. Rep

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/#review77606 --- Could you please add another test case in kglobalshortcuttests

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On March 17, 2015, 7:10 a.m., Martin Gräßlin wrote: > > src/kglobalaccel.h, line 269 > > > > > > what are the "some cases"? I removed the "some cases". I was thinking about kwin/effects/desktopgrid/desktopgri

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On March 17, 2015, 7:10 a.m., Martin Gräßlin wrote: > > src/kglobalaccel.h, lines 256-260 > > > > > > please add an > > @since > > and > > @param For the @since I looked at the value in the CMakeLi

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/ --- (Updated March 21, 2015, 12:39 p.m.) Review request for KDE Frameworks, M

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/#review77901 --- I doubt the test will work on the CI system as there we don't

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/#review77902 --- autotests/kglobalshortcuttest.cpp (lines 424 - 428)

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On March 22, 2015, 11:07 a.m., Martin Gräßlin wrote: > > src/kglobalaccel.h, line 266 > > > > > > can I get your time machine? > > https://www.kde.org/announcements/kde-frameworks-5.8.0.php ;-) yes, sure, ple

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/#review77912 --- Can you clarify why this is needed? If it is something we alwa

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/ --- (Updated March 22, 2015, 4:05 p.m.) Review request for KDE Frameworks, Ma

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On March 22, 2015, 11:08 a.m., Martin Gräßlin wrote: > > autotests/kglobalshortcuttest.cpp, lines 424-428 > > > > > > please compare with the other test cases - there are verifications on > > whether kglobalac

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote: > > src/kglobalaccel.h, line 260 > > > > > > typo in following About why it is needed: see KGlobalShortcutTest::testLoadShortcutFromGlobalSettings: short

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On mar. 22, 2015, 3:56 p.m., Albert Astals Cid wrote: > > src/kglobalaccel.h, line 260 > > > > > > typo in following > > Gregor Mi wrote: > About why it is needed: see > KGlobalShortcutTest::testLoadShort

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote: > > src/kglobalaccel.h, line 260 > > > > > > typo in following > > Gregor Mi wrote: > About why it is needed: see > KGlobalShortcutTest::testLoadShor

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On March 22, 2015, 11:08 a.m., Martin Gräßlin wrote: > > autotests/kglobalshortcuttest.cpp, lines 424-428 > > > > > > please compare with the other test cases - there are verifications on > > whether kglobalac

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On March 22, 2015, 4:56 p.m., Albert Astals Cid wrote: > > src/kglobalaccel.h, line 260 > > > > > > typo in following > > Gregor Mi wrote: > About why it is needed: see > KGlobalShortcutTest::testLoadShor

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/#review78410 --- I finally managed to make most the master unit tests pass: **

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote: > > src/kglobalaccel.h, line 260 > > > > > > typo in following > > Gregor Mi wrote: > About why it is needed: see > KGlobalShortcutTest::testLoadShor

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/ --- (Updated April 2, 2015, 2:56 p.m.) Review request for KDE Frameworks, Mar

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On mar. 22, 2015, 3:56 p.m., Albert Astals Cid wrote: > > src/kglobalaccel.h, line 260 > > > > > > typo in following > > Gregor Mi wrote: > About why it is needed: see > KGlobalShortcutTest::testLoadShort

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/ --- (Updated April 3, 2015, 5:50 p.m.) Review request for KDE Frameworks, Mar

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote: > > src/kglobalaccel.h, line 260 > > > > > > typo in following > > Gregor Mi wrote: > About why it is needed: see > KGlobalShortcutTest::testLoadShor

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On mar. 22, 2015, 3:56 p.m., Albert Astals Cid wrote: > > src/kglobalaccel.h, line 260 > > > > > > typo in following > > Gregor Mi wrote: > About why it is needed: see > KGlobalShortcutTest::testLoadShort

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote: > > src/kglobalaccel.h, line 260 > > > > > > typo in following > > Gregor Mi wrote: > About why it is needed: see > KGlobalShortcutTest::testLoadShor

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/#review78472 --- src/kglobalaccel.h (line 372)

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On April 4, 2015, 9:14 vorm., Gregor Mi wrote: > > src/kglobalaccel.h, line 372 > > > > > > NOTE that this causes compile error in libKF5XmlGui > > > > > > /home/gregor/dev/kf5/usr/lib64/libKF5Xml

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On mar. 22, 2015, 3:56 p.m., Albert Astals Cid wrote: > > src/kglobalaccel.h, line 260 > > > > > > typo in following > > Gregor Mi wrote: > About why it is needed: see > KGlobalShortcutTest::testLoadShort

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On März 22, 2015, 3:56 nachm., Albert Astals Cid wrote: > > src/kglobalaccel.h, line 260 > > > > > > typo in following > > Gregor Mi wrote: > About why it is needed: see > KGlobalShortcutTest::testLoadSho

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On mar. 22, 2015, 3:56 p.m., Albert Astals Cid wrote: > > src/kglobalaccel.h, line 260 > > > > > > typo in following > > Gregor Mi wrote: > About why it is needed: see > KGlobalShortcutTest::testLoadShort

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/#review78505 --- Honestly, i think the problem here is that the function just d

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote: > > src/kglobalaccel.h, line 260 > > > > > > typo in following > > Gregor Mi wrote: > About why it is needed: see > KGlobalShortcutTest::testLoadShor

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

> On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote: > > src/kglobalaccel.h, line 260 > > > > > > typo in following > > Gregor Mi wrote: > About why it is needed: see > KGlobalShortcutTest::testLoadShor